Fix flows create --step_configs not applying handler configs#1002
Open
Fix flows create --step_configs not applying handler configs#1002
Conversation
applyStepConfigsToFlow() only accepted singular handler_slug and handler_config keys, but the CLI and admin UI pass the plural forms handler_slugs (array) and handler_configs (keyed object). Now handles both: - handler_slugs: iterates and calls add_handler for each slug with its matching config from handler_configs - handler_slug/handler_config: still works as before (backward compat) This means flows create --step_configs with handler_slugs and handler_configs now works in a single command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001
Summary
applyStepConfigsToFlow()inFlowHelpersonly accepted singularhandler_slugandhandler_configkeys, but the CLI--step_configsJSON and admin UI pass plural forms (handler_slugsarray andhandler_configskeyed object)flows create --step_configsto create steps with empty handler configs, requiring 3 separate commands per step as a workaroundFix
applyStepConfigsToFlow()now handles both plural and singular forms:handler_slugs(array): iterates each slug and callsadd_handlerwith its matching config fromhandler_configshandler_slug/handler_config(singular): still works as before for backward compat with the--handler-configCLI pathBefore
After
The single
flows create --step_configscommand works correctly — handlers and their configs are applied in one shot.