refactor: align Chat REST handlers with core Abilities API contract#1000
Merged
refactor: align Chat REST handlers with core Abilities API contract#1000
Conversation
Remove legacy fallback paths from all Chat REST session handlers
(list, get, delete). REST handlers are thin wrappers around abilities.
Introduce execute_ability() helper that follows core's WP_Ability::execute()
contract:
- wp_get_ability() directly (WP 6.9+ guaranteed)
- Core handles input validation, permissions, callback execution
- WP_Error pass-through for core failures
- Temporary shim for legacy { success: false } array convention (#999)
Every session handler is now a one-liner: extract params → execute_ability().
Part of the broader ability contract alignment tracked in #999.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all legacy fallback paths from Chat REST session handlers. REST is a thin wrapper around abilities — nothing else.
function_exists('wp_get_ability')guards (WP 6.9 minimum)execute_ability()helper that follows core'sWP_Ability::execute()contractWP_Errorreturns (from core) and legacy{ success: false }arrays (from our callbacks)Net: -61 lines (79 added, 140 removed)
Before
After
Part of the broader ability contract alignment tracked in #999.