Bugfix to allow playing 2 different samples which map to the same value in KeyEnum#286
Closed
DeannaGelbart wants to merge 2 commits intoExternalizable:masterfrom
DeannaGelbart:fix-simultaneous-play-bug
Closed
Bugfix to allow playing 2 different samples which map to the same value in KeyEnum#286DeannaGelbart wants to merge 2 commits intoExternalizable:masterfrom DeannaGelbart:fix-simultaneous-play-bug
DeannaGelbart wants to merge 2 commits intoExternalizable:masterfrom
DeannaGelbart:fix-simultaneous-play-bug
Conversation
Author
|
Oh, there is already a PR for this |
Author
|
I closed this because I thought it duplicated another open PR, but later looking at the diffs I saw I took a different approach (changing the pressed array to store a tag while the other PR removes the pressed array). So I'm re-opening it. |
Author
|
Link to the other PR https://github.com/Externalizable/bongo.cat/pull/286/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bugfix allows playing e.g. the first bongo (A key) and the first piano key (1 key) at the same time. Previously you could only play one or the other at a time because they map to the same value in
KeyEnum.