feat: DB builder component #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droguljic
reviewed
Dec 4, 2025
MiroDojkic
reviewed
Dec 5, 2025
Comment on lines
64
to
78
| public useExistingParameterGroup( | ||
| parameterGroupName: pulumi.Input<string>, | ||
| ): this { | ||
| this._parameterGroupName = parameterGroupName; | ||
|
|
||
| return this; | ||
| } | ||
|
|
||
| public withCustomParameterGroup( | ||
| customParameterGroupArgs: pulumi.Input<aws.rds.ParameterGroupArgs>, | ||
| ): this { | ||
| this._customParameterGroupArgs = customParameterGroupArgs; | ||
|
|
||
| return this; | ||
| } |
Member
There was a problem hiding this comment.
Would it make sense to consolidate this with the method overload?
In that case we could have withParameterGroup that can receive args or name which should simplify developer experience as they don't have to think about which method to choose, or try to understand different methods.
Contributor
There was a problem hiding this comment.
I agree with the overload approach, just one small note on that. We are dropping the parameter group creation from the Database component, so the builder should be updated to create a parameter group and pass its name to the Database component during the construction. This will also imply use of transformations to properly set the parent on the parameter group resource.
mandryllo
force-pushed
the
feat/db-v2-builder
branch
2 times, most recently
from
70b006e to
99feda2
Compare
droguljic
requested changes
Dec 9, 2025
mandryllo
force-pushed
the
feat/db-v2-builder
branch
from
ba8fd24 to
3e74298
Compare
bornast
approved these changes
Dec 10, 2025
# Conflicts: # src/v2/components/database/index.ts
mandryllo
force-pushed
the
feat/db-v2-builder
branch
from
b052530 to
63c1af7
Compare
droguljic
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second one in order to resolve #70 and it will represent just the DB builder component.