Skip to content

Avoid module-load crash from eager currentActivity access #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MegaManSec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid module-load crash from eager currentActivity access #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions android/src/main/java/com/expensify/wallet/WalletModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,11 @@ class WalletModule internal constructor(context: ReactApplicationContext) :
const val E_INVALID_DATA = "E_INVALID_DATA"
}

private val activity = reactApplicationContext.currentActivity ?: throw ActivityNotFoundException()
private val tapAndPayClient: TapAndPayClient = TapAndPay.getClient(activity)
private val activity: Activity
get() = reactApplicationContext.currentActivity ?: throw ActivityNotFoundException()

private val tapAndPayClient: TapAndPayClient
get() = TapAndPay.getClient(activity)
private var pendingCreateWalletPromise: Promise? = null
private var pendingPushTokenizePromise: Promise? = null

Expand Down