Skip to content

Prevent hanging promise when enrollment VC is already presented #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MegaManSec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent hanging promise when enrollment VC is already presented #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ios/WalletManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@ open class WalletManager: UIViewController {
RCTPresentedViewController()?.present(enrollViewController, animated: true, completion: nil)
} else {
self.logInfo(message: "EnrollViewController is already presented.")
self.presentAddPaymentPassCompletionHandler = nil
completion(.error, [
"errorMessage": "EnrollViewController is already presented."
])
}
}
}
Expand Down Expand Up @@ -165,7 +169,7 @@ open class WalletManager: UIViewController {
let paymentPasses = passLibrary.passes(of: .payment)
if paymentPasses.isEmpty {
self.logInfo(message: "No passes found in Wallet.")
return -1
return NSNumber(value: -1)
}

for pass in paymentPasses {
Expand All @@ -174,7 +178,7 @@ open class WalletManager: UIViewController {
return NSNumber(value: securePassElement.passActivationState.rawValue)
}
}
return -1
return NSNumber(value: -1)
}

@objc public func getCardStatusBySuffix(last4Digits: NSString) -> NSNumber {
Expand Down