refactor: normalize card activation event across platforms#57
Open
refactor: normalize card activation event across platforms#57
Conversation
Skalakid
requested review from
Copilot and
zfurtak
and removed request for
Copilot
zfurtak
approved these changes
Jan 22, 2026
Collaborator
zfurtak
left a comment
zfurtak
left a comment
There was a problem hiding this comment.
LGTM, just let me test it first 👍
| | **UserAddress** | Structured address used for cardholder verification. | `name: string`,<br>`addressOne: string`,<br>`addressTwo: string`,<br>`city: string`,<br>`administrativeArea: string`,<br>`countryCode: string`,<br>`postalCode: string`,<br>`phoneNumber: string` | | ||
| | **IOSCardData** | Data related to a card that is to be added on iOS platform. | `network: string`,<br>`activationData: string`,<br>`encryptedPassData: string`,<br>`ephemeralPublicKey: string`,<br>`cardHolderTitle: string`,<br>`cardHolderName: string`,<br>`lastDigits: string`,<br>`cardDescription: string`,<br>`cardDescriptionComment: string` | | ||
| | **onCardActivatedPayload** | Data used by listener to notice when a card’s status changes. | `tokenId: string`,<br> `actionStatus: 'activated' \| 'canceled'`<br> | | ||
| | **onCardActivatedPayload** | Data used by listener to notice when a card's status changes. | `tokenId: string`,<br> `status: 'activated' \| 'canceled'`<br> | |
Collaborator
There was a problem hiding this comment.
I guess CardStatus type should also be changed?
Collaborator
Author
There was a problem hiding this comment.
I think no, here we have card state, but from the event listener, we are getting a status of the provisioning (success -> activated / failure -> canceled)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR normalizes the
onCardActivatedevent payload structure across iOS and Android platforms to ensure consistency and improve developer experience.Changes:
actionStatus→statusin the TypeScript type definitionstate→statusandserialNumber→tokenIdto match Android implementation"active"→"activated"for consistency with iOSstatusproperty nameRelated Issues
#53
Manual Tests
statusandtokenIdpropertiesstatus: "activated"instead ofstatus: "active"status: "canceled"is emittedLinked PRs
N/A