Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
@wcastand any updates when this will be merged? |
|
@adnandothussain that's not on me unfortunately, i made the Pr never received feedback so before i ever look at conflict, i expect them to spend some time for review before i spend more time on it especially since conflict is just package maintenance most likely. |
|
Thank you for your response @wcastand |
|
You can do yeah we have it in prod right now |
|
By using your Gist https://gist.github.com/wcastand/4160c31062e085b043e4d78953642150 I have created expo plugin. Will it work in Prod? |
|
well test, i don't know your setup so i can't guarantee it, it works for us at least. 😅 |
|
Sorry guys for waiting! Thanks a lot for collaboration!! 💪 |
|
Could you resolve conflicts? |
example-expo/App.js
Outdated
There was a problem hiding this comment.
Also, I can't run the expo app, I'm getting errors when launching it on iOS
There was a problem hiding this comment.
same on Android
ERROR ExceptionsManager should be set up after React DevTools to avoid console.error arguments mutation
ERROR [TypeError: property is not writable]
ERROR [TypeError: Cannot read property 'default' of undefined]
ERROR [TypeError: property is not writable]
ERROR [TypeError: Cannot read property 'default' of undefined]
|
@wcastand than you very much for the PR, sorry for the delay with the review; I didn't have the bandwidth to check your changes. I left some comments. Please resolve them, and we can proceed with merging your changes. The plugin itself looks good and works well |
- Convert example-expo/App.js to TypeScript (App.tsx) - Remove plugin/tsconfig.tsbuildinfo and add *.tsbuildinfo to .gitignore - Move Expo plugin documentation to Installation section in README - Revert package.json formatting from tabs to spaces while keeping functional changes - Regenerate package-lock.json with correct formatting - Fix expo app to use simple UI that won't cause runtime errors Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
well i give up lol i rebase but getting package conflict in a loop, honestly i wanted to help but it's been like 6 month and kind of not up to deal with package json conflict ever again at this point lol. |
|
@wcastand I totally get it. Don't worry, the core logic you wrote is what matters. I will take it from here. Thanks for all the effort you put into this and sorry for the delay with the review |
|
thanks for the package, and sorry again for not figure this one out, package json conflict got to me this morning 😅 |
Details
Adding an expo plugin to allow to use this library with expo CNG.
Adding documentation on how to configure and do.
I make the draft quickly mostly because i'm rusty on open source contribution. never really did an expo plugin as part of a public lib (always internal plugins and modules). We use biome and bun so didn't use prettier/eslint and npm in 4 years pretty much 😅
so i will need some guidance or help to make this a clean PR, sorry in advance.
Related Issues
#31
Manual Tests
i added an expo example app with the plugin in the config, not sure how to test since it needs the private lib for google pay.
TODO