Add support for detecting iOS 26#885
Merged
inimaga merged 2 commits intoExpensify:mainfrom Oct 29, 2025
Merged
Conversation
Contributor
Author
|
@situchan @srikarparsi The PR to add support for detecting iOS 26 is ready. |
inimaga
reviewed
Oct 28, 2025
| const {browser, os} = parser.getResult(); | ||
|
|
||
| let osVersion = os.version; | ||
| if (browser.name === 'Mobile Safari' && browser.major === '26' && os.name === 'iOS' && os.version === '18.6') { |
Contributor
There was a problem hiding this comment.
Is there a reason we are hardcoding to 18.6? What if we parsed it and tried to match all variants of ios18 (Not just 18.6)?
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Aaah Gotcha. Thanks for the link. @dmkt9 Mind including a short clarifying comment then, for posterity.
inimaga
previously approved these changes
Oct 28, 2025
Contributor
Author
Hi @inimaga, I have just added a comment to clarify that. |
inimaga
approved these changes
Oct 29, 2025
Contributor
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ Expensify/App#73240
PROPOSAL: Expensify/App#73240 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Precondition: user signed in with account A on main testing iOS 26 device and account B on secondary
Open staging.new.expensify.com
Navigate to chat with account B
Tap on the composer to open the virtual keyboard
Start typing on the secondary device where account B is logged in
Look at the typing indicator text below the composer.
Paste the following text into the composer to trigger the error message:
[] Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Aenean commodo ligula eget dolor. Aenean ma (creating task message with more than 100 characters)
Verify that the typing indicator and error messages should be fully visible and not overlapped by the site header when the composer is focused and virtual keyboard is open
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
The issue does not occur.
Android: mWeb Chrome
android.chrome.mp4
iOS: Native
The issue does not occur.
iOS: mWeb Safari
iOS 26:
ios.safari.26.mp4
iOS 18:
ios.safari.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4