Already closed openpage fix#1
Open
eVoloshchak wants to merge 3 commits into
Open
Conversation
These were the only PdfDocument methods using an unconditional check(!isClosed) instead of handleAlreadyClosed(), so a configured AlreadyClosedBehavior.IGNORE never reached them. A render that lands on a just-closed document threw IllegalStateException on the renderer thread (PdfiumCore.renderPageBitmap -> openPage), which the barteksc RenderingHandler does not catch, crashing the app. Now they route through handleAlreadyClosed() like every sibling method and, when IGNORE is set, return a page bound to the closed document so all further ops no-op via the existing doc.isClosed guards.
Author
|
Coming from Expensify/App#94894 |
eVoloshchak
commented
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ Expensify/App#93839
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."