Part 3 - Thread personalDetailsList through hasExpensifyGuidesEmails and currentUserLogin through isJoinRequestInAdminRoom

[Krishna2323]

Explanation of Change

Fixed Issues

$ #66413
PROPOSAL:

Tests

1. Navigate to any report — verify it loads (no "Not Found" page)
2. Navigate to a report via deep link (paste a report URL) — verify it loads correctly
3. Open a thread and tap the ancestor report — verify navigation works
4. Close and reopen the app — verify you land on the correct last-accessed report
5. Check the LHN — verify all expected reports are visible (no missing chats)
6. Go offline → navigate between reports → go back online — verify no crashes
7. Delete a report (leave a chat) — verify you're redirected to another report, not a blank/error screen

• Verify that no errors appear in the JS console

Offline tests

• Same as tests

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-07-06.01-56-08.mp4

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useSidebarOrderedReports.tsx	92.13% <100.00%> (+0.37%)	⬆️
src/libs/DebugUtils.ts	68.76% <ø> (ø)
.../AppNavigator/Navigators/ReportsSplitNavigator.tsx	92.59% <100.00%> (ø)
src/libs/OptionsListUtils/index.ts	86.17% <100.00%> (+0.01%)	⬆️
src/libs/SidebarUtils.ts	80.41% <100.00%> (+0.05%)	⬆️
src/libs/actions/Report/index.ts	70.37% <100.00%> (+0.41%)	⬆️
src/libs/navigateAfterOnboarding.ts	87.50% <100.00%> (ø)
src/pages/inbox/ReportRouteParamHandler.tsx	70.58% <ø> (ø)
src/pages/inbox/report/withReportOrNotFound.tsx	97.50% <100.00%> (+0.35%)	⬆️
src/libs/UnreadIndicatorUpdater/index.ts	93.75% <0.00%> (-2.00%)	⬇️
... and 6 more
... and 11 files with indirect coverage changes

[Krishna2323]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e81a05fc27

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit: fa33392e38

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

@codex review

[Krishna2323]

@MelvinBot review

[MelvinBot]

Review

Solid, well-scoped Part 3. The migration threads personalDetailsList/currentUserLogin/guidesEmailsByReport through the guide-email and admin-room checks while every new param keeps a fallback to the old module-level state, so behavior is preserved and the change stays incremental. All call sites of the re-signatured functions (canAccessReport, canCurrentUserOpenReport, canSeeDefaultRoom, findLastAccessedReport, isJoinRequestInAdminRoom) are updated, and the new object-param hasGuidesEmails is required so TS enforces coverage. Test coverage is thorough. A few non-blocking notes:

1. Perf: hasExpensifyGuidesEmails now runs for every report, not just default rooms

Previously hasExpensifyGuidesEmails was only reached inside canSeeDefaultRoom, i.e. gated behind isDefaultRoom(report). It's now computed eagerly for every report in two hot paths:

• OptionsListUtils/index.ts:2556 — inside the getValidOptions filter, once per option
• UnreadIndicatorUpdater/index.ts:105 — once per report

For high-traffic accounts this adds a participants scan + extractEmailDomain per report where before it was skipped for non-default-rooms. Consider gating with isDefaultRoom(report) (returning false otherwise) to keep the previous cost profile.

2. Readability/DRY: reuse resolveHasGuidesEmails in findLastAccessedReport

ReportUtils.ts:2493 hand-rolls the precedence:

!((report?.reportID && guidesEmailsByReport?.[report.reportID]) ?? hasExpensifyGuidesEmails(...))

This is correct (a present false short-circuits the ?? fallback, absent → undefined → fallback), but it's subtle and duplicates the logic already centralized in resolveHasGuidesEmails — which even reads more precisely via reportID in guidesEmailsByReport. Calling resolveHasGuidesEmails({participantAccountIDs, guidesEmailsByReport, reportID: report?.reportID}) here would be clearer and keep the two branches consistent.

3. Consistency: memoize the new hasExpensifyGuidesEmailsSelector subscriptions

These four useOnyx calls pass a freshly-created selector each render with no memoization or deps array:

• AncestorReportActionItem.tsx:109
• DebugReportPage.tsx:101
• withReportOrNotFound.tsx:92
• withReportAndReportActionOrNotFound.tsx:58

hasExpensifyGuidesEmailsSelector(participantAccountIDs) returns a new function on every render, so the selector reruns unnecessarily. This is inconsistent with the neighboring reportOwnerSelector in DebugReportPage, which is memoized and passed with a [reportOwnerSelector] deps array. Suggest the same pattern:

const guidesEmailsSelector = useMemo(() => hasExpensifyGuidesEmailsSelector(participantAccountIDs), [participantAccountIDs]);
const [hasGuidesEmails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: guidesEmailsSelector}, [guidesEmailsSelector]);

4. Minor: findLastAccessedReport param position

Inserting guidesEmailsByReport as the 2nd positional arg (shifting openOnAdminRoom/excludeReportID/reportNameValuePairs) is the kind of change that's easy to get subtly wrong at a call site — every caller now threads an undefined in the middle. TS enforces it today, but appending the new param (or moving to an options object) would be less error-prone going forward. Not blocking.

Nothing here is a correctness blocker — the fallbacks are sound and the incremental TODO trail is clear.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 32a6c0bdf1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

@MelvinBot I have made the changes, please review again!

[MelvinBot]

Re-review — all feedback addressed ✅

Thanks, the four points from my last review are all resolved and the changes are behavior-preserving:

1. Perf gating — hasExpensifyGuidesEmails is now only computed for default rooms in both hot paths (OptionsListUtils/index.ts:2557 and UnreadIndicatorUpdater/index.ts:105), returning false otherwise. This is safe: hasGuidesEmails is only ever read inside canSeeDefaultRoom, which canAccessReport gates behind the same isDefaultRoom(report) check — so false for non-default-rooms is never consumed. Restores the original cost profile. 👍

2. DRY — findLastAccessedReport now reuses resolveHasGuidesEmails instead of the hand-rolled precedence expression. Clearer and consistent with the other branch. 👍

3. Selector memoization — all four subscriptions (DebugReportPage, AncestorReportActionItem, withReportAndReportActionOrNotFound, withReportOrNotFound) now memoize the selector with [participantAccountIDs] and pass a [guidesEmailsSelector] deps array — matching the neighboring reportOwnerSelector convention. 👍

4. Param-position nit was non-blocking; fine to leave as-is.

No further concerns from me. LGTM pending CI (typecheck/tests) staying green.

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]