Fix Track workspace admins room visibility in LHN

[emkhalid]

Explanation of Change

Marks the #admins room created during Track-business onboarding so it remains visible in the LHN while active, without pinning it or changing regular workspace rooms. Archived rooms are excluded from the LHN while remaining accessible through search.

Fixed Issues

$ #92431
PROPOSAL: #92431 (comment)

Tests

1. Create a new account.
2. Select Track expenses for my business.
3. Complete onboarding.
4. Open Inbox.
5. Verify the workspace #admins room is visible in the LHN.
6. Verify the room is not pinned.
7. Open another chat.
8. Verify #admins remains visible.

• Verify that no errors appear in the JS console

Offline tests

Not applicable. Completing Track-business onboarding and creating the workspace requires an active network connection.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native-admin.mp4

Android: mWeb Chrome

android-web-admin.mp4

iOS: Native

ios-native-admin.mp4

iOS: mWeb Safari

ios-web-admin.mp4

MacOS: Chrome / Safari

macos-admin.mp4

[emkhalid]

@linhvovan29546 I tested the following cases, and they all passed:

1. Track-business onboarding
2. Navigating between chats
3. Reloading or restarting the app
4. Opening #admins through search
5. Deleting the Track workspace
6. Searching after workspace deletion
7. Deleting the workspace while viewing #admins
8. Regular workspace creation
9. Regular #admins unpinning
10. Regular workspace deletion
11. Track Personal onboarding
12. Multiple workspaces

One case needs confirmation: after signing out and signing back in, the active Track workspace #admins room is no longer visible in the LHN because the client-only marker is cleared.

And I think this is outside the expected scope of this issue.

[melvin-bot]

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38be94bf7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Do not pin Track onboarding admins rooms

When shouldShowTrackAdminRoomInLHN is true for Track-business onboarding, the report still inherits isPinned: shouldPinAdminRoomByDefault() from the optimistic chat data, which is true for normal non-Expensify/Guides accounts. That means the new onboarding #admins room is pinned instead of merely kept visible, so the documented QA path with a regular new account will show a pinned room; override isPinned to false for this marked Track onboarding case.

Useful? React with 👍 / 👎.

[emkhalid]

Addressed

[linhvovan29546]

Hmm, if the user clears the cache, will the admin room be gone?