Skip to content

Show the travel card icon for other members' travel expenses#95320

Draft
allgandalf wants to merge 6 commits into
Expensify:mainfrom
allgandalf:travel-card-icon-feed-country
Draft

Show the travel card icon for other members' travel expenses#95320
allgandalf wants to merge 6 commits into
Expensify:mainfrom
allgandalf:travel-card-icon-feed-country

Conversation

@allgandalf

Copy link
Copy Markdown
Contributor

Explanation of Change

The travel card icon only showed for your own travel expenses. TypeCell derived it from isTravelCard(card), and card comes from your own card list (cardList in Onyx), so another member's travel card resolved to undefined and fell back to the generic Expensify Card icon. The card name column worked for everyone because that string is resolved on the backend and ships on the transaction.

The backend now sends feedCountry on the transaction, so this keys the icon on transaction.feedCountry === CONST.TRAVEL.PROGRAM_TRAVEL_US and keeps isTravelCard(card) as a fallback for old cached transactions that predate the field. The icon fix lives in TypeCell, so it covers every surface that renders it (search, report view, unreported expenses, duplicate/merge, recently added). Also keyed the card name column on feedCountry so another member's travel expense shows the localized name, not just the fixed backend string.

Depends on the backend change that adds feedCountry to the flat search response.

Fixed Issues

$ #95078
PROPOSAL:

Tests

  1. On a travel billing enabled workspace, sign in as an admin
  2. Go to Search and open the Expenses view
  3. Find a travel card expense that belongs to another member of the workspace (not one of your own expenses)
  4. Verify it shows the travel card icon (card with a plane), the same icon your own travel expenses show
  5. Verify the Card column for that expense shows the travel invoicing name
  6. Verify your own travel expenses and regular Expensify Card expenses still show the correct icons
  • Verify that no errors appear in the JS console

Offline tests

  1. Load the Expenses search once while online so the results are cached
  2. Turn off the network connection
  3. Verify another member's travel expense still shows the travel card icon and the travel invoicing name (the icon and name derive from feedCountry on the cached transaction, no network call)

QA Steps

  1. On a travel billing enabled workspace, sign in as an admin
  2. Go to Search and open the Expenses view
  3. Find a travel card expense that belongs to another member of the workspace
  4. Verify it shows the travel card icon (card with a plane), the same as your own travel expenses
  5. Verify the Card column shows the travel invoicing name
  6. Verify regular Expensify Card and personal card expenses still show the correct icons
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant