[HOLD #95340] refactor getReportPreviewMessage to use translate param part 1#95152
[HOLD #95340] refactor getReportPreviewMessage to use translate param part 1#95152daledah wants to merge 2 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| isForListPreview?: boolean; | ||
| /** This can be either a report preview action or the IOU action. This will be the original report preview action in cases where `iouReportAction` was unwrapped from a report preview action. Otherwise, it will be the same as `iouReportAction`. */ | ||
| originalReportAction?: OnyxInputOrEntry<ReportAction>; | ||
| // TODO: We'll remove the optional (?) modifier from the translate parameter once https://github.com/Expensify/App/issues/66430 is completed |
There was a problem hiding this comment.
❌ CONSISTENCY-11 (docs)
This change adds a // TODO: comment describing deferred work (removing the optional ? modifier from the translate parameter once issue #66430 is completed). Per contributingGuides/philosophies/OVERENGINEERING.md, future work should be captured in the linked GitHub issue rather than left as an in-code TODO, which is invisible to planning and tends to rot in the codebase.
Remove the TODO comment and rely on the referenced GitHub issue (#66430) to track making the translate parameter required:
/** ... */
originalReportAction?: OnyxInputOrEntry<ReportAction>;
translate?: LocalizedTranslate;
};Reviewed at: 9bff627 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Explanation of Change
Fixed Issues
$ #66430
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-03.at.13.50.55.mov