Add Rillet and Campfire accounting integrations#89688
Draft
Add Rillet and Campfire accounting integrations#89688
Conversation
…ng page Add Rillet and Campfire as external accounting integrations. The Connect button for each opens the partner's integration page: - Rillet: https://www.rillet.com/integrations/expensify - Campfire: https://campfire.ai/integrations Co-authored-by: Nick Tooker <NickTooker@users.noreply.github.com>
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 62ffb53e..911ac1bf 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -6100,6 +6100,10 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Campfire';
default: {
return '';
}
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index fd242c5a..f71e03f8 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -6103,7 +6103,7 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
netsuite: 'NetSuite',
intacct: 'Sage Intacct',
rillet: 'Rillet',
- campfire: 'Campfire',
+ campfire: 'Feu de camp',
sap: 'SAP',
oracle: 'Oracle',
microsoftDynamics: 'Microsoft Dynamics',
@@ -6121,6 +6121,10 @@ _Pour des instructions plus détaillées, [visitez notre site d’aide](${CONST.
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Feu de camp';
default: {
return '';
}
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 688e9001..c25c96f0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6071,7 +6071,7 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
netsuite: 'NetSuite',
intacct: 'Sage Intacct',
rillet: 'Rillet',
- campfire: 'Campfire',
+ campfire: 'Falò',
sap: 'SAP',
oracle: 'Oracle',
microsoftDynamics: 'Microsoft Dynamics',
@@ -6089,6 +6089,10 @@ _Per istruzioni più dettagliate, [visita il nostro sito di assistenza](${CONST.
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Falò';
default: {
return '';
}
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 7f77af74..efc39e9b 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6021,6 +6021,10 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Campfire';
default: {
return '';
}
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 6cdd5f51..faecae8f 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6052,7 +6052,7 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
netsuite: 'NetSuite',
intacct: 'Sage Intacct',
rillet: 'Rillet',
- campfire: 'Campfire',
+ campfire: 'Kampvuur',
sap: 'SAP',
oracle: 'Oracle',
microsoftDynamics: 'Microsoft Dynamics',
@@ -6070,6 +6070,10 @@ _Voor meer gedetailleerde instructies, [bezoek onze help-site](${CONST.NETSUITE_
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Kampvuur';
default: {
return '';
}
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 049a7c87..683c56b4 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6044,7 +6044,7 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
netsuite: 'NetSuite',
intacct: 'Sage Intacct',
rillet: 'Rillet',
- campfire: 'Campfire',
+ campfire: 'Ognisko',
sap: 'SAP',
oracle: 'Oracle',
microsoftDynamics: 'Microsoft Dynamics',
@@ -6062,6 +6062,10 @@ _Aby uzyskać bardziej szczegółowe instrukcje, [odwiedź naszą stronę pomocy
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Ognisko';
default: {
return '';
}
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index f14b56c2..075c4b7b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6069,6 +6069,10 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Campfire';
default: {
return '';
}
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 4a038f54..805a376a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -5919,6 +5919,10 @@ _如需更详细的说明，请[访问我们的帮助网站](${CONST.NETSUITE_IM
return 'NetSuite';
case CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT:
return 'Sage Intacct';
+ case CONST.POLICY.CONNECTIONS.NAME.RILLET:
+ return 'Rillet';
+ case CONST.POLICY.CONNECTIONS.NAME.CAMPFIRE:
+ return 'Campfire';
default: {
return '';
}
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
Contributor
Author
|
Fixed the failing Prettier check: the |
Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
Contributor
Author
|
Fixed the failing typecheck: added missing |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
Contributor
Author
|
Fixed the failing ESLint check: removed unused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adds Rillet and Campfire as accounting integrations on the Workspace > Accounting page.
When a user clicks "Setup" for either integration, it opens the partner's external integrations page:
Changes include:
CONST.POLICY.CONNECTIONS(NAME, ROUTE, NAME_USER_FRIENDLY, ACCOUNTING_CONNECTION_NAMES)ConnectToRilletFlowandConnectToCampfireFlowcomponents that open external URLsPolicy.tsfor the new connectionsgetAccountingIntegrationDatawith cases for Rillet and CampfireFixed Issues
$ #89687
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari