Skip to content

[No QA] chore: Remove @typescript-eslint/no-deprecated ESLint suppressions #89685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roryabraham wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[No QA] chore: Remove @typescript-eslint/no-deprecated ESLint suppressions #89685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc74753
chore: remove no-deprecated eslint suppressions
roryabraham May 6, 2026
eafaf62
Rebuild gh actions
roryabraham May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/actions/javascript/proposalPoliceComment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11696,7 +11696,6 @@ async function run() {
const duplicateCheckPrompt = proposalPolice_1.default.getPromptForNewProposalDuplicateCheck(previousProposal.body, newProposalBody);
const duplicateCheckResponse = await openAI.promptAssistant(assistantID, duplicateCheckPrompt);
let similarityPercentage = 0;
// eslint-disable-next-line @typescript-eslint/no-deprecated -- TODO: refactor `parseAssistantResponse` to use `promptResponses` instead
const parsedDuplicateCheckResponse = openAI.parseAssistantResponse(duplicateCheckResponse);
core.startGroup('Parsed Duplicate Check Response');
console.log('parsedDuplicateCheckResponse: ', parsedDuplicateCheckResponse);
Expand Down Expand Up @@ -11734,7 +11733,6 @@ async function run() {
? proposalPolice_1.default.getPromptForNewProposalTemplateCheck(payload.comment?.body)
: proposalPolice_1.default.getPromptForEditedProposal(payload.changes.body?.from, payload.comment?.body);
const assistantResponse = await openAI.promptAssistant(assistantID, prompt);
// eslint-disable-next-line @typescript-eslint/no-deprecated -- TODO: refactor `parseAssistantResponse` to use `promptResponses` instead
const parsedAssistantResponse = openAI.parseAssistantResponse(assistantResponse);
core.startGroup('Parsed Assistant Response');
console.log('parsedAssistantResponse: ', parsedAssistantResponse);
Expand Down Expand Up @@ -12554,23 +12552,19 @@ class OpenAIUtils {
*/
async promptAssistant(assistantID, userMessage) {
// 1. Create a thread
const thread = await (0, retryWithBackoff_1.default)(() =>
// eslint-disable-next-line @typescript-eslint/no-deprecated
this.client.beta.threads.create({
const thread = await (0, retryWithBackoff_1.default)(() => this.client.beta.threads.create({
messages: [{ role: OpenAIUtils.USER, content: userMessage }],
}), { isRetryable: (err) => OpenAIUtils.isRetryableError(err) });
// 2. Create a run on the thread
let run = await (0, retryWithBackoff_1.default)(() =>
// eslint-disable-next-line @typescript-eslint/no-deprecated
this.client.beta.threads.runs.create(thread.id, {
let run = await (0, retryWithBackoff_1.default)(() => this.client.beta.threads.runs.create(thread.id, {
// eslint-disable-next-line @typescript-eslint/naming-convention
assistant_id: assistantID,
}), { isRetryable: (err) => OpenAIUtils.isRetryableError(err) });
// 3. Poll for completion
let response = '';
let count = 0;
while (!response && count < OpenAIUtils.MAX_POLL_COUNT) {
// eslint-disable-next-line @typescript-eslint/naming-convention, @typescript-eslint/no-deprecated
// eslint-disable-next-line @typescript-eslint/naming-convention
run = await this.client.beta.threads.runs.retrieve(run.id, { thread_id: thread.id });
if (run.status !== OpenAIUtils.OPENAI_RUN_COMPLETED) {
count++;
Expand All @@ -12579,7 +12573,6 @@ class OpenAIUtils {
});
continue;
}
// eslint-disable-next-line @typescript-eslint/no-deprecated
for await (const message of this.client.beta.threads.messages.list(thread.id)) {
if (message.role !== OpenAIUtils.ASSISTANT) {
continue;
Expand Down
2 changes: 0 additions & 2 deletions .github/actions/javascript/proposalPoliceComment/proposalPoliceComment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ async function run() {
const duplicateCheckPrompt = PROPOSAL_POLICE_TEMPLATES.getPromptForNewProposalDuplicateCheck(previousProposal.body, newProposalBody);
const duplicateCheckResponse = await openAI.promptAssistant(assistantID, duplicateCheckPrompt);
let similarityPercentage = 0;
// eslint-disable-next-line @typescript-eslint/no-deprecated -- TODO: refactor `parseAssistantResponse` to use `promptResponses` instead
const parsedDuplicateCheckResponse = openAI.parseAssistantResponse<DuplicateProposalResponse>(duplicateCheckResponse);
core.startGroup('Parsed Duplicate Check Response');
console.log('parsedDuplicateCheckResponse: ', parsedDuplicateCheckResponse);
Expand Down Expand Up @@ -188,7 +187,6 @@ async function run() {
: PROPOSAL_POLICE_TEMPLATES.getPromptForEditedProposal(payload.changes.body?.from, payload.comment?.body);

const assistantResponse = await openAI.promptAssistant(assistantID, prompt);
// eslint-disable-next-line @typescript-eslint/no-deprecated -- TODO: refactor `parseAssistantResponse` to use `promptResponses` instead
const parsedAssistantResponse = openAI.parseAssistantResponse<AssistantResponse>(assistantResponse);
core.startGroup('Parsed Assistant Response');
console.log('parsedAssistantResponse: ', parsedAssistantResponse);
Expand Down
Loading
Loading