88162: Reports page - Custom report title briefly shows'Chat Report' when clicking a report row#89661
88162: Reports page - Custom report title briefly shows'Chat Report' when clicking a report row#89661abbasifaizan70 wants to merge 2 commits intoExpensify:mainfrom
Conversation
…when clicking a report row
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d40000d83
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…reatingNewReport is true
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
I changed openReport so optimistic Onyx updates only set reportName when a real existing name is already present, instead of falling back to DEFAULT_REPORT_NAME ("Chat Report").
This prevents the temporary overwrite to "Chat Report" during navigation, so the custom formula-based title no longer flickers before the API response restores it.
Fixed Issues
$ #88162
PROPOSAL: #88162 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-06.at.2.26.20.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-05-06.at.2.25.31.AM.mov
iOS: Native
Screen.Recording.2026-05-06.at.2.17.07.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-06.at.2.18.21.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-06.at.2.09.58.AM.mp4