[NoQA] Add Gusto approval mode settings#89653
[NoQA] Add Gusto approval mode settings#89653ShridharGoel wants to merge 11 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0299513468
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| notSet: 'Not set', | ||
| approvalModeDescription: 'Members and managers are set up to sync with Gusto.', | ||
| approvalModeWarningTitle: 'Change approval mode?', | ||
| approvalModeWarningPrompt: (helpSiteURL: string) => `Are you sure you would like to change the approval mode for this workspace? Learn more about the different Gusto-enabled workflow modes in our <a href="${helpSiteURL}">help site</a>.`, | ||
| approvalModeWarningConfirm: 'Change approval mode', |
There was a problem hiding this comment.
Localize new Gusto approval-mode copy for locale files
The new workspace.hr.gusto keys were added with English text in localized files, so non-English users will see untranslated copy on the new approval-mode UI. This is a user-facing regression introduced in this commit (the same pattern appears across de.ts, fr.ts, it.ts, ja.ts, nl.ts, pl.ts, pt-BR.ts, and zh-hans.ts), and these strings should be translated per locale instead of duplicating the English values.
Useful? React with 👍 / 👎.
Explanation of Change
Adds the Gusto approval mode settings for the HR workspace page.
Fixed Issues
$ #87013
PROPOSAL:
Tests
gustoNewDot).Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-06.at.9.24.02.AM.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-05-06.at.9.25.11.AM.mov