Skip to content

Fix incorrect month display in Expense line chart for zh/ja locales #89651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
marufsharifi wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Draft

Fix incorrect month display in Expense line chart for zh/ja locales #89651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dccd2b3
Fix month display in Expense line chart for Chinese and Japanese locales
marufsharifi May 5, 2026
02d531c
Merge branch 'main' into fix/expense-line-chart-month-i18n-display
marufsharifi May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added assets/fonts/NotoSansSC-Months.ttf
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/components/Charts/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** Font families used by all chart label components (Paragraph API multi-font fallback). */
const CHART_FONT_FAMILIES = ['ExpensifyNeue', 'NotoSansSymbols'];
const CHART_FONT_FAMILIES = ['ExpensifyNeue', 'NotoSansSymbols', 'NotoSansSCMonths'];

/** Number of Y-axis ticks (including zero) */
const Y_AXIS_TICK_COUNT = 5;
Expand Down
1 change: 1 addition & 0 deletions src/components/Charts/hooks/useChartFontManager/useChartFontManager.native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ function useChartFontManager(): SkTypefaceFontProvider | null {
require('@assets/fonts/native/ExpensifyNeue-BoldItalic.otf') as DataModule,
],
NotoSansSymbols: [require('@assets/fonts/NotoSans-Symbols.ttf') as DataModule],
NotoSansSCMonths: [require('@assets/fonts/NotoSansSC-Months.ttf') as DataModule],
});
}

Expand Down
1 change: 1 addition & 0 deletions src/components/Charts/hooks/useChartFontManager/useChartFontManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ function useChartFontManager(): SkTypefaceFontProvider | null {
webFont(require('@assets/fonts/web/ExpensifyNeue-BoldItalic.woff2') as string),
],
NotoSansSymbols: [webFont(require('@assets/fonts/NotoSans-Symbols.ttf') as string)],
NotoSansSCMonths: [webFont(require('@assets/fonts/NotoSansSC-Months.ttf') as string)],
});
}

Expand Down
Loading