Feat: add a new category within the category list by daledah · Pull Request #86177 · Expensify/App

daledah · 2026-03-24T08:11:45Z

Explanation of Change

Fixed Issues

$ #85681
PROPOSAL: #85681 (comment)

Tests

Create a new workspace
Go to workspace chat and create an expense
In Confirm details page, select the category
Verify that: there is a plus button on the top right
Click this button
Enter the category name
Verify that: a new category is created

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

a-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

codecov · 2026-03-24T08:19:39Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
...onfirmationList/hooks/useConfirmationValidation.ts	`85.18% <100.00%> (+0.27%)`	⬆️
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/libs/Violations/ViolationsUtils.ts	`77.13% <100.00%> (+0.05%)`	⬆️
src/pages/iou/request/step/StepScreenWrapper.tsx	`100.00% <ø> (ø)`
...iou/request/step/withFullTransactionOrNotFound.tsx	`95.65% <ø> (ø)`
.../iou/request/step/withWritableReportOrNotFound.tsx	`88.46% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.84% <0.00%> (-0.01%)`	⬇️
src/ROUTES.ts	`17.21% <0.00%> (-0.07%)`	⬇️
.../pages/iou/request/step/IOURequestStepCategory.tsx	`0.00% <0.00%> (ø)`
... and 1 more
... and 9 files with indirect coverage changes

melvin-bot · 2026-03-25T04:26:25Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af61ad1801

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

dylanexpensify · 2026-03-26T12:55:57Z

@ahmedGaber93 please complete review 🙇‍♂️

ahmedGaber93 · 2026-03-26T16:43:51Z

@daledah I think the UX flow might be missing something. After adding a new category, it should be applied directly to the expense instead of returning to the list and requiring the user to select it again.

CC @dylanexpensify for confirmation.

ahmedGaber93 · 2026-03-26T16:44:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

a.mp4

Android: mWeb Chrome

20260330212429779.mp4

iOS: HybridApp

Screen.Recording.2026-04-13.at.10.07.19.PM.mov

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

20260330180222407.mp4

ahmedGaber93 · 2026-03-27T12:22:49Z

@Expensify/design WDYT #86177 (comment)?

shawnborton · 2026-03-27T14:05:10Z

After adding a new category, it should be applied directly to the expense instead of returning to the list and requiring the user to select it again.

Correct, that was what we had in mind!

shawnborton · 2026-03-27T14:05:24Z

Let us know when that is fixed and we can run some test builds.

JmillsExpensify

LGTM

ahmedGaber93 · 2026-03-29T21:35:48Z

@daledah could you please address this comment: #86177 (comment) and let me know when this is ready for review again?

daledah · 2026-03-30T09:08:40Z

Screen.Recording.2026-03-30.at.16.08.25.mov

@ahmedGaber93 i updated

github-actions · 2026-03-30T09:15:25Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

shawnborton · 2026-03-30T09:33:04Z

I noticed that a sound plays when a category is created. What's the thinking there? Is that how category creation currently works?

shawnborton · 2026-03-30T09:34:31Z

Otherwise this is testing well and looks good to me!

daledah · 2026-04-28T07:43:17Z

@ahmedGaber93 i updated, please check again

daledah · 2026-04-30T09:48:31Z

Looks like the failing test is not related to this PR

daledah · 2026-05-04T06:22:16Z

this PR is ready to merge @amyevans

amyevans · 2026-05-04T13:21:17Z

Thanks! I started reviewing last week but will finish it up later today!

amyevans

LGTM!

github-actions · 2026-05-04T14:48:15Z

🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-04T14:53:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86177.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9adead4-b945a7d-cb0313a2b08b8fe7510c79d6b5742ee5f271d52d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9adead4-b945a7d-cc020b0e9cd610d1f41fef2b18add62bf7fdafbd/index.html

Web 🕸️
https://86177.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jponikarchuk · 2026-05-05T19:05:17Z

Deploy Blocker #89635 was identified to be related to this PR.

OSBotify · 2026-05-05T19:16:46Z

🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-05T19:22:51Z

🤖 Help site update needed — draft PR created.

PR #86177 adds the ability for Workspace Admins to create a new category directly from the category picker during expense creation/editing. The existing help article (Create-expense-categories.md) did not document this flow.

Changes made:

Added a new section "How to add a category while creating or editing an expense" to Create-expense-categories.md
Updated keywords and internal scope to cover inline category creation

Draft PR: #89642

Please mark it as "Ready for review" when it is ready for review.

jponikarchuk · 2026-05-05T19:45:28Z

Deploy Blocker #89646 was identified to be related to this PR.

jponikarchuk · 2026-05-05T20:11:13Z

Deploy Blocker #89650 was identified to be related to this PR.

mitarachim · 2026-05-05T21:31:14Z

Deploy Blocker #89663 was identified to be related to this PR.

francoisl · 2026-05-05T21:32:21Z

Third blocker so far, prepping a revert #89662

[CP Staging] Revert #86177 "Feat: add a new category within the category list"

[CP Staging] Revert #86177 "Feat: add a new category within the category list" (cherry picked from commit 94727c1) (cherry-picked to staging by francoisl)

This reverts commit 9adead4, reversing changes made to b8a58d9.

daledah added 2 commits March 19, 2026 00:27

feature: add a new category within the category list

eca73c4

Merge branch 'main' into fix/85681

feb7bdf

melvin-bot Bot assigned daledah Mar 24, 2026

Merge branch 'main' into fix/85681

af61ad1

daledah marked this pull request as ready for review March 25, 2026 04:26

daledah requested review from a team as code owners March 25, 2026 04:26

melvin-bot Bot requested review from ahmedGaber93 and removed request for a team March 25, 2026 04:26

melvin-bot Bot requested review from JmillsExpensify and removed request for a team March 25, 2026 04:26

chatgpt-codex-connector Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepCategory.tsx Outdated

JmillsExpensify previously approved these changes Mar 29, 2026

View reviewed changes

daledah added 2 commits March 30, 2026 14:51

Merge branch 'main' into fix/85681

abd7805

fix auto select created category

623faa6

daledah dismissed JmillsExpensify’s stale review via 623faa6 March 30, 2026 09:05

This comment has been minimized.

Sign in to view

ahmedGaber93 approved these changes Apr 28, 2026

View reviewed changes

melvin-bot Bot requested a review from amyevans April 28, 2026 17:00

daledah added 2 commits April 30, 2026 16:16

resolve conflict

7dc939f

fix lint

9504eb4

amyevans approved these changes May 4, 2026

View reviewed changes

amyevans merged commit 9adead4 into Expensify:main May 4, 2026
42 of 43 checks passed

OSBotify mentioned this pull request May 5, 2026

Deploy Checklist: New Expensify 2026-05-05 #89627

Open

84 tasks

jponikarchuk mentioned this pull request May 5, 2026

Expense - RHP closes after refreshing Add category page and returning to previous page #89635

Closed

7 tasks

jponikarchuk mentioned this pull request May 5, 2026

[$250] Introduce the ability to add a new category within the category list #85681

Open

MelvinBot mentioned this pull request May 5, 2026

Docs updates for E/A#86177 Add inline category creation from expense flow #89642

Draft

2 tasks

jponikarchuk mentioned this pull request May 5, 2026

Expense - Blank space is shown below Save button in Add category page #89646

Closed

7 tasks

jponikarchuk mentioned this pull request May 5, 2026

Expense - Category RHP remains open after creating workspace and adding a new category #89650

Closed

7 tasks

francoisl mentioned this pull request May 5, 2026

[CP Staging] Revert #86177 "Feat: add a new category within the category list" #89662

Merged

52 tasks

mitarachim mentioned this pull request May 5, 2026

Invoice - Add category button is not responsive when sending invoice #89663

Closed

7 tasks

Julesssss added a commit that referenced this pull request May 5, 2026

Merge pull request #89662 from Expensify/francois-revert-86177

94727c1

[CP Staging] Revert #86177 "Feat: add a new category within the category list"

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request May 5, 2026

Revert "Merge pull request Expensify#86177 from daledah/fix/85681"

f8fdb20

This reverts commit 9adead4, reversing changes made to b8a58d9.

Conversation

daledah commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

dylanexpensify commented Mar 26, 2026

Uh oh!

ahmedGaber93 commented Mar 26, 2026

Uh oh!

ahmedGaber93 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmedGaber93 commented Mar 27, 2026

Uh oh!

shawnborton commented Mar 27, 2026

Uh oh!

shawnborton commented Mar 27, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Mar 29, 2026

Uh oh!

daledah commented Mar 30, 2026

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

This comment has been minimized.

shawnborton commented Mar 30, 2026

Uh oh!

shawnborton commented Mar 30, 2026

Uh oh!

daledah commented Apr 28, 2026

Uh oh!

daledah commented Apr 30, 2026

Uh oh!

daledah commented May 4, 2026

Uh oh!

amyevans commented May 4, 2026

Uh oh!

amyevans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

jponikarchuk commented May 5, 2026

Uh oh!

OSBotify commented May 5, 2026

Uh oh!

MelvinBot commented May 5, 2026

Uh oh!

jponikarchuk commented May 5, 2026

Uh oh!

jponikarchuk commented May 5, 2026

Uh oh!

mitarachim commented May 5, 2026

Uh oh!

francoisl commented May 5, 2026

daledah commented Mar 24, 2026 •

edited

Loading

codecov Bot commented Mar 24, 2026 •

edited by github-actions Bot

Loading

ahmedGaber93 commented Mar 26, 2026 •

edited

Loading