Skip to content

Remove unnecessary custom types from translations - Batch 14 #84399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jakubstec wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove unnecessary custom types from translations - Batch 14 #84399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2a78a1
(refactor): simplify translation param types to standalone params part1
jakubstec Mar 5, 2026
f2714c1
simplify translation param types to standalone params
jakubstec Mar 6, 2026
893253d
revert ResolutionConstraintsParams type deletion
jakubstec Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 41 additions & 56 deletions src/languages/de.ts
View file
Open in desktop

Large diffs are not rendered by default.

95 changes: 41 additions & 54 deletions src/languages/en.ts
View file
Open in desktop

Large diffs are not rendered by default.

65 changes: 32 additions & 33 deletions src/languages/es.ts
View file
Open in desktop

Large diffs are not rendered by default.

98 changes: 41 additions & 57 deletions src/languages/fr.ts
View file
Open in desktop

Large diffs are not rendered by default.

96 changes: 41 additions & 55 deletions src/languages/it.ts
View file
Open in desktop

Large diffs are not rendered by default.

98 changes: 41 additions & 57 deletions src/languages/ja.ts
View file
Open in desktop

Large diffs are not rendered by default.

98 changes: 41 additions & 57 deletions src/languages/nl.ts
View file
Open in desktop

Large diffs are not rendered by default.

130 changes: 65 additions & 65 deletions src/languages/params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ type ReportArchiveReasonsInvoiceReceiverPolicyDeletedParams = {
policyName: string;
};

type CreatedReportForUnapprovedTransactionsParams = {
reportUrl: string;
reportName: string;
};
// type CreatedReportForUnapprovedTransactionsParams = {
// reportUrl: string;
// reportName: string;
// };

type WorkspacesListRouteParams = {
workspacesListRoute: string;
Expand All @@ -88,17 +88,17 @@ type ResolutionConstraintsParams = {minHeightInPx: number; minWidthInPx: number;

type NotAllowedExtensionParams = {allowedExtensions: string[]};

type WeSentYouMagicSignInLinkParams = {login: string; loginType: string};
// type WeSentYouMagicSignInLinkParams = {login: string; loginType: string};

type StepCounterParams = {step: number; total?: number; text?: string};

type UserIsAlreadyMemberParams = {login: string; name: string};
// type UserIsAlreadyMemberParams = {login: string; name: string};

type ParentNavigationSummaryParams = {reportName?: string; workspaceName?: string};

type UpdatedTheRequestParams = {valueName: string; newValueToDisplay: string; oldValueToDisplay: string};
// type UpdatedTheRequestParams = {valueName: string; newValueToDisplay: string; oldValueToDisplay: string};

type UpdatedTheDistanceMerchantParams = {translatedChangedField: string; newMerchant: string; oldMerchant: string; newAmountToDisplay: string; oldAmountToDisplay: string};
// type UpdatedTheDistanceMerchantParams = {translatedChangedField: string; newMerchant: string; oldMerchant: string; newAmountToDisplay: string; oldAmountToDisplay: string};

type WalletProgramParams = {walletProgram: string};

Expand All @@ -110,7 +110,7 @@ type ViolationsInvoiceMarkupParams = {invoiceMarkup: number};

type ViolationsMaxAgeParams = {maxAge: number};

type ViolationsMissingTagParams = {tagName?: string} | undefined;
// type ViolationsMissingTagParams = {tagName?: string} | undefined;

type ViolationsModifiedAmountParams = {type?: ViolationDataType; displayPercentVariance?: number};

Expand All @@ -122,27 +122,27 @@ type ViolationsOverLimitParams = {formattedLimit: string};

type ViolationsPerDayLimitParams = {formattedLimit: string};

type ViolationsReceiptRequiredParams = {formattedLimit?: string; category?: string};
// type ViolationsReceiptRequiredParams = {formattedLimit?: string; category?: string};

type ViolationsCustomRulesParams = {message: string};

type ViolationsRterParams = {
brokenBankConnection: boolean;
isAdmin: boolean;
isTransactionOlderThan7Days: boolean;
member?: string;
rterType?: ValueOf<typeof CONST.RTER_VIOLATION_TYPES>;
companyCardPageURL?: string;
connectionLink?: string;
isPersonalCard?: boolean;
isMarkAsCash?: boolean;
};
// type ViolationsRterParams = {
// brokenBankConnection: boolean;
// isAdmin: boolean;
// isTransactionOlderThan7Days: boolean;
// member?: string;
// rterType?: ValueOf<typeof CONST.RTER_VIOLATION_TYPES>;
// companyCardPageURL?: string;
// connectionLink?: string;
// isPersonalCard?: boolean;
// isMarkAsCash?: boolean;
// };

type ViolationsTagOutOfPolicyParams = {tagName?: string} | undefined;
// type ViolationsTagOutOfPolicyParams = {tagName?: string} | undefined;

type ViolationsProhibitedExpenseParams = {prohibitedExpenseTypes: string | string[]};
// type ViolationsProhibitedExpenseParams = {prohibitedExpenseTypes: string | string[]};

type ViolationsTaxOutOfPolicyParams = {taxName?: string} | undefined;
// type ViolationsTaxOutOfPolicyParams = {taxName?: string} | undefined;

type OptionalParam<T> = Partial<T>;

Expand All @@ -152,17 +152,17 @@ type ChangeFieldParams = {oldValue?: string; newValue: string; fieldName: string

type UpdatedPolicyCategoryMaxAmountNoReceiptParams = {categoryName: string; oldValue?: string; newValue: string};

type UpdatedPolicyTaxParams = {taxName: string; oldValue?: string | boolean | number; newValue?: string | boolean | number; updatedField?: string};
// type UpdatedPolicyTaxParams = {taxName: string; oldValue?: string | boolean | number; newValue?: string | boolean | number; updatedField?: string};

type UpdatedPolicyTagParams = {tagListName: string; tagName?: string; enabled?: boolean; count?: string};
// type UpdatedPolicyTagParams = {tagListName: string; tagName?: string; enabled?: boolean; count?: string};

type UpdatedPolicyTagNameParams = {oldName: string; newName: string; tagListName: string};
// type UpdatedPolicyTagNameParams = {oldName: string; newName: string; tagListName: string};

type UpdatedPolicyTagFieldParams = {oldValue?: string; newValue: string; tagName: string; tagListName: string; updatedField: string};
// type UpdatedPolicyTagFieldParams = {oldValue?: string; newValue: string; tagName: string; tagListName: string; updatedField: string};

type UpdatedPolicyTagListParams = {tagListName: string};

type UpdatedPolicyTagListRequiredParams = {tagListsName: string; isRequired: boolean};
// type UpdatedPolicyTagListRequiredParams = {tagListsName: string; isRequired: boolean};

type UpdatePolicyCustomUnitTaxEnabledParams = {newValue: boolean};

Expand All @@ -172,23 +172,23 @@ type UpdatePolicyCustomUnitDefaultCategoryParams = {customUnitName: string; newV

type UpdatePolicyCustomUnitParams = {oldValue: string; newValue: string; customUnitName: string; updatedField: string};

type UpdatedPolicyCustomUnitSubRateParams = {customUnitName: string; customUnitRateName: string; customUnitSubRateName: string; oldValue: string; newValue: string; updatedField: string};
// type UpdatedPolicyCustomUnitSubRateParams = {customUnitName: string; customUnitRateName: string; customUnitSubRateName: string; oldValue: string; newValue: string; updatedField: string};

type RemovedPolicyCustomUnitSubRateParams = {customUnitName: string; customUnitRateName: string; removedSubRateName: string};
// type RemovedPolicyCustomUnitSubRateParams = {customUnitName: string; customUnitRateName: string; removedSubRateName: string};

type AddedOrDeletedPolicyReportFieldParams = {fieldType: string; fieldName?: string};

type UpdatedPolicyReportFieldDefaultValueParams = {fieldName?: string; defaultValue?: string};
// type UpdatedPolicyReportFieldDefaultValueParams = {fieldName?: string; defaultValue?: string};

type UpdatedPolicyApprovalRuleParams = {oldApproverEmail: string; oldApproverName?: string; newApproverEmail: string; newApproverName?: string; field: string; name: string};

type UpdatedPolicyPreventSelfApprovalParams = {oldValue: string; newValue: string};
// type UpdatedPolicyPreventSelfApprovalParams = {oldValue: string; newValue: string};

type UpdatedPolicyOwnershipParams = {oldOwnerEmail: string; oldOwnerName: string; policyName: string};

type UpdatedPolicyTimeEnabledParams = {enabled?: boolean};

type UpdatedPolicyTimeRateParams = {newRate?: string; oldRate?: string};
// type UpdatedPolicyTimeRateParams = {newRate?: string; oldRate?: string};

type UpdatedPolicyAutoHarvestingParams = {enabled: boolean};

Expand Down Expand Up @@ -329,10 +329,10 @@ type InvalidValueParams = {
expectedValues: string;
};

type WorkspaceYouMayJoin = {
domain: string;
email: string;
};
// type WorkspaceYouMayJoin = {
// domain: string;
// email: string;
// };

type WorkEmailResendCodeParams = {
workEmail: string | undefined;
Expand All @@ -342,10 +342,10 @@ type WorkEmailMergingBlockedParams = {
workEmail: string | undefined;
};

type WorkspaceMemberList = {
employeeCount: number;
policyOwner: string;
};
// type WorkspaceMemberList = {
// employeeCount: number;
// policyOwner: string;
// };

type WorkspaceLockedPlanTypeParams = {
count: number;
Expand Down Expand Up @@ -415,35 +415,35 @@ export type {
ReportArchiveReasonsClosedParams,
ReportArchiveReasonsMergedParams,
ReportArchiveReasonsInvoiceReceiverPolicyDeletedParams,
CreatedReportForUnapprovedTransactionsParams,
ReportArchiveReasonsRemovedFromPolicyParams,
// CreatedReportForUnapprovedTransactionsParams,
ResolutionConstraintsParams,
SizeExceededParams,
StepCounterParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
// UpdatedTheDistanceMerchantParams,
// UpdatedTheRequestParams,
UsePlusButtonParams,
UserIsAlreadyMemberParams,
// UserIsAlreadyMemberParams,
UserSplitParams,
ViolationsCashExpenseWithNoReceiptParams,
ViolationsConversionSurchargeParams,
ViolationsInvoiceMarkupParams,
ViolationsMaxAgeParams,
ViolationsMissingTagParams,
// ViolationsMissingTagParams,
ViolationsModifiedAmountParams,
ViolationsOverAutoApprovalLimitParams,
ViolationsOverCategoryLimitParams,
ViolationsOverLimitParams,
ViolationsPerDayLimitParams,
ViolationsReceiptRequiredParams,
// ViolationsReceiptRequiredParams,
ViolationsCustomRulesParams,
ViolationsRterParams,
ViolationsTagOutOfPolicyParams,
ViolationsProhibitedExpenseParams,
ViolationsTaxOutOfPolicyParams,
// ViolationsRterParams,
// ViolationsTagOutOfPolicyParams,
// ViolationsProhibitedExpenseParams,
// ViolationsTaxOutOfPolicyParams,
WaitingOnBankAccountParams,
WalletProgramParams,
WeSentYouMagicSignInLinkParams,
// WeSentYouMagicSignInLinkParams,
WelcomeEnterMagicCodeParams,
WelcomeToRoomParams,
ZipCodeExampleFormatParams,
Expand All @@ -461,24 +461,24 @@ export type {
DisconnectPromptParams,
DisconnectTitleParams,
OptionalParam,
WorkspaceYouMayJoin,
WorkspaceMemberList,
// WorkspaceYouMayJoin,
// WorkspaceMemberList,
WorkspaceLockedPlanTypeParams,
CustomUnitRateParams,
UpdatedPolicyTagListParams,
UpdatedPolicyTagListRequiredParams,
UpdatedPolicyPreventSelfApprovalParams,
// UpdatedPolicyTagListRequiredParams,
// UpdatedPolicyPreventSelfApprovalParams,
UpdatedPolicyTimeEnabledParams,
UpdatedPolicyTimeRateParams,
// UpdatedPolicyTimeRateParams,
WorkEmailResendCodeParams,
WorkEmailMergingBlockedParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagFieldParams,
UpdatedPolicyReportFieldDefaultValueParams,
RemovedPolicyCustomUnitSubRateParams,
UpdatedPolicyCustomUnitSubRateParams,
// UpdatedPolicyTagParams,
// UpdatedPolicyTaxParams,
// UpdatedPolicyTagNameParams,
// UpdatedPolicyTagFieldParams,
// UpdatedPolicyReportFieldDefaultValueParams,
// RemovedPolicyCustomUnitSubRateParams,
// UpdatedPolicyCustomUnitSubRateParams,
YourPlanPriceValueParams,
AddedOrDeletedPolicyReportFieldParams,
UpdatedPolicyManualApprovalThresholdParams,
Expand Down
Loading
Loading