[No QA] Add reasonAttributes to OptionsListSkeletonView usage sites#84396
Open
sosek108 wants to merge 1 commit intoExpensify:mainfrom
Open
[No QA] Add reasonAttributes to OptionsListSkeletonView usage sites#84396sosek108 wants to merge 1 commit intoExpensify:mainfrom
sosek108 wants to merge 1 commit intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
ShridharGoel
reviewed
Mar 6, 2026
| if (shouldShowLoadingPlaceholder) { | ||
| return customLoadingPlaceholder ?? <OptionsListSkeletonView shouldStyleAsTable={shouldUseUserSkeletonView} />; | ||
| const reasonAttributes: SkeletonSpanReasonAttributes = { | ||
| context: 'BaseSelectionList', |
Contributor
There was a problem hiding this comment.
This is generic, but context is supposed to identify where this is rendered. Because this is a shared component, every caller will now emit the same value, so Sentry still won’t identify which actual screen is stuck. Is that expected?
ShridharGoel
reviewed
Mar 6, 2026
| const renderListEmptyContent = () => { | ||
| if (shouldShowLoadingPlaceholder) { | ||
| const reasonAttributes: SkeletonSpanReasonAttributes = { | ||
| context: 'BaseSelectionListWithSections', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Added
reasonAttributesto all usage sites ofOptionsListSkeletonViewso Sentry spans carry structured metadata about why a loading indicator is visible. This helps engineers debug infinite skeleton loading states.Part of #81683
Fixed Issues
$ #83397
PROPOSAL:
Tests
Offline tests
N/A — this change only adds telemetry metadata, no behavioral changes
QA Steps
N/A — this change only adds telemetry metadata, no behavioral changes
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari