[No-QA] Defer startup imports#84390
Draft
elirangoshen wants to merge 2 commits intoExpensify:mainfrom
Draft
Conversation
UnreadIndicatorUpdater and replaceOptimisticReportWithActualReport both register heavy Onyx collection subscriptions (waitForCollectionCallback: true on COLLECTION.REPORT and COLLECTION.REPORT_ACTIONS) at module import time, competing with critical-path startup reads. Deferring them via requestAnimationFrame after the splash hides removes this I/O contention without missing any data, since both modules receive a full collection snapshot on first subscription. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Defers loading of two non-critical modules —
UnreadIndicatorUpdaterandreplaceOptimisticReportWithActualReport— until after the splash screen hides, instead of importing them statically at module load time.Both modules register heavy Onyx.connectWithoutView subscriptions with waitForCollectionCallback: true on large collections
(COLLECTION.REPORT, COLLECTION.REPORT_ACTIONS, COLLECTION.REPORT_DRAFT_COMMENT). Whenimported statically, these subscriptions compete for I/O with the critical-path Onyx reads that gate the splash screen
(SESSION, IS_CHECKING_PUBLIC_ROOM, preferredLocale). Deferring them removes that contentionand allows startup reads to complete faster.
This is safe because both modules use
waitForCollectionCallback: true, meaning they receive a full snapshot of all current data when they first subscribe — no events or updates are missed regardless of when theyload.
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari