Optimize defaultExpensifyCardSelector by removing translate dependency

[husamdaifalla01-cmyk]

Explanation of Change

defaultExpensifyCardSelector (~13ms per render) was causing unnecessary re-renders in useSearchTypeMenuSections due to two compounding issues:

1. Unstable selector reference: The selector was wrapped in an inline closure capturing translate, creating a new function reference on every render. This caused useOnyx to re-evaluate the selector on every render cycle — even when the underlying card data hadn't changed.

2. Unnecessary work inside the selector: The selector called getCardFeedsForDisplay({}, allCards, translate), where the first argument {} meant the entire first loop (including getOriginalCompanyFeeds) was dead work. The translate parameter was never actually invoked in this code path since the name is always hardcoded as CONST.EXPENSIFY_CARD.BANK. Additionally, Object.values(cards)?.at(0) allocated a full array just to take the first element.

Changes made:

• Extracted getExpensifyCardFeedsForDisplay in CardFeedUtils.ts — a focused function that only iterates cards looking for Expensify Card bank entries, without needing translate or processing company card feeds. getCardFeedsForDisplay now delegates to this function internally via Object.assign, eliminating code duplication.
• Rewrote defaultExpensifyCardSelector in Card.ts — calls the extracted function directly (no translate param), uses for...of early return instead of Object.values().at(0).
• Removed the inline closure in useSearchTypeMenuSections.ts — the stable module-level selector is passed directly to useOnyx, eliminating the unstable reference and removing the useLocalize dependency.
• Updated unit tests in CardTest.ts to reflect the new selector signature.

Reassure benchmark results (head-to-head, old vs new on same machine):

Scenario	Old (ms)	New (ms)	Improvement
1k mixed cards	0.145	0.103	29% faster
1k Expensify cards	0.193	0.174	10% faster
5k mixed cards	0.941	0.512	46% faster

The dominant performance win is the elimination of per-render re-evaluation (not captured by measureFunction) — the unstable closure previously forced useOnyx to re-run the selector on every render of useSearchTypeMenuSections, which is mounted in the always-visible NavigationTabBar.

Fixed Issues

$ #82425
PROPOSAL: #82425 (comment)

Tests

1. Open the app and navigate to the Search/Reports page
2. Tap between different navigation tabs (Inbox, Search, Settings) multiple times
3. Verify navigation remains responsive and the Expensify Card data loads correctly in search type menus
4. If you have an Expensify Card, verify it still appears correctly in the search type dropdown
5. If you do not have an Expensify Card, verify no card-related errors appear
6. Create a new expense and verify card selection still works as expected

• Verify that no errors appear in the JS console

Offline tests

1. Turn off network connection
2. Navigate between tabs (Inbox, Search, Settings)
3. Verify no crashes or errors — the selector handles undefined/empty card lists gracefully
4. Reconnect and verify card data loads correctly

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — no UI changes. This is a pure performance optimization (selector refactor).

Android: Native

N/A — no UI changes

Android: mWeb Chrome

N/A — no UI changes

iOS: Native

N/A — no UI changes

iOS: mWeb Safari

N/A — no UI changes

MacOS: Chrome / Safari

N/A — no UI changes

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[husamdaifalla01-cmyk]

I have read the CLA Document and I hereby sign the CLA

[ZhenjaHorbach]

Conflicts

[ZhenjaHorbach]

And even if there's no UI changes, we need to record videos to confirm that nothing is broken

[ZhenjaHorbach]

Let's add tests for this util

[husamdaifalla01-cmyk]

And even if there's no UI changes, we need to record videos to confirm that nothing is broken

Thanks for the review! I've added unit tests for getExpensifyCardFeedsForDisplay in the latest push. It covers empty/undefined inputs, deduplication, mixed card lists, and equivalence with getCardFeedsForDisplay.

Regarding the video recordings, since this is a pure logic refactor (selector internals + removing an unused translate dependency) with no UI or rendering changes, would web (Chrome/Safari) and mWeb recordings be sufficient? Happy to set up native environments if needed, just wanted to check first.

[ZhenjaHorbach]

And even if there's no UI changes, we need to record videos to confirm that nothing is broken

Thanks for the review! I've added unit tests for getExpensifyCardFeedsForDisplay in the latest push. It covers empty/undefined inputs, deduplication, mixed card lists, and equivalence with getCardFeedsForDisplay.

Regarding the video recordings, since this is a pure logic refactor (selector internals + removing an unused translate dependency) with no UI or rendering changes, would web (Chrome/Safari) and mWeb recordings be sufficient? Happy to set up native environments if needed, just wanted to check first.

web (Chrome/Safari) and mWeb will be enough

[husamdaifalla01-cmyk]

And even if there's no UI changes, we need to record videos to confirm that nothing is broken

Thanks for the review! I've added unit tests for getExpensifyCardFeedsForDisplay in the latest push. It covers empty/undefined inputs, deduplication, mixed card lists, and equivalence with getCardFeedsForDisplay.
Regarding the video recordings, since this is a pure logic refactor (selector internals + removing an unused translate dependency) with no UI or rendering changes, would web (Chrome/Safari) and mWeb recordings be sufficient? Happy to set up native environments if needed, just wanted to check first.

web (Chrome/Safari) and mWeb will be enough

Screen.Recording.2026-03-06.at.3.51.36.AM.mov

Screen.Recording.2026-03-06.at.3.48.08.AM.2.mov