-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[CP Staging] Revert "fix: infinite loading appears when logging in via hellogorgeous link" #78641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Approved, but it seems the bug can still be reproduced. |
|
Thanks! Qa confirmed they could repro in staging and not on this adhoc https://expensify.enterprise.slack.com/archives/C09V78U42D8/p1767196466987169?thread_ts=1767193250.570699&channel=C09V78U42D8&message_ts=1767196466.987169 |
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit 9d16906) (cherry-picked to staging by mountiny)
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.89-6 🚀
|
Reverts #75808
Testing #78626