Remove isFocused from BaseSearchList and renderItem #78632
+5
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Part of reducing parent (Search page) re-renders when the user opens a report. Switching isFocused to false causes additional work for the list and list items, which may no longer be necessary.
Originally, this change was introduced to fix this issue: #69097, origin PR: #69204
Fixed Issues
$ #77173
PROPOSAL:
Tests
Log in with a new account
Create a Workspace and an expense in WS chat
Navigate to "Reports"
Note that expenses preview are correctly displayed.
Navigate to "Inbox" again.
Return to "Reports" using device´s back button.
Note that the expense shows up again
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2025-12-31.at.12.30.54.mov
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Uploading Screen Recording 2025-12-31 at 14.30.16.mov…