Update role descriptions to be more concise #78595
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
puneetlath
and removed request for
a team
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. |
Contributor
|
@jamesdeanexpensify we should also update this in the other languages as mentioned in this comment: #78595 (comment) |
Contributor
Author
|
Are you by chance able to help with that? I don't think I'm set up properly to do that yet. |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 02f0d2db..8366613b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2011,8 +2011,8 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredForAdminsHeader: 'Zwei-Faktor-Authentifizierung erforderlich',
twoFactorAuthIsRequiredForAdminsTitle: 'Bitte aktivieren Sie die Zwei-Faktor-Authentifizierung',
twoFactorAuthIsRequiredXero:
- 'Ihre Xero-Buchhaltungsverbindung erfordert die Verwendung der Zwei-Faktor-Authentifizierung. Bitte aktivieren Sie sie, um Expensify weiterhin nutzen zu können.',
- twoFactorAuthIsRequiredCompany: 'Ihr Unternehmen verlangt die Verwendung von Zwei-Faktor-Authentifizierung. Bitte aktivieren Sie sie, um Expensify weiterhin verwenden zu können.',
+ 'Ihre Xero-Buchhaltungsverbindung erfordert die Verwendung der Zwei-Faktor-Authentifizierung. Bitte aktivieren Sie diese, um Expensify weiter verwenden zu können.',
+ twoFactorAuthIsRequiredCompany: 'Ihr Unternehmen verlangt die Verwendung der Zwei-Faktor-Authentifizierung. Um Expensify weiter zu verwenden, aktivieren Sie sie bitte.',
twoFactorAuthCannotDisable: '2FA kann nicht deaktiviert werden',
twoFactorAuthRequired: 'Für Ihre Xero-Verbindung ist eine Zwei-Faktor-Authentifizierung (2FA) erforderlich und sie kann nicht deaktiviert werden.',
},
@@ -3845,9 +3845,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} – Zuletzt synchronisiert am ${formattedDate}`,
authenticationError: (connectionName: string) => `Verbindung mit ${connectionName} aufgrund eines Authentifizierungsfehlers nicht möglich.`,
learnMore: 'Mehr erfahren',
- memberAlternateText: 'Mitglieder können Berichte einreichen und genehmigen.',
- adminAlternateText: 'Admins haben vollen Bearbeitungszugriff auf alle Berichte und Workspace-Einstellungen.',
- auditorAlternateText: 'Prüfer können Berichte anzeigen und kommentieren.',
+ memberAlternateText: 'Berichte einreichen und freigeben.',
+ adminAlternateText: 'Berichte und Arbeitsbereichseinstellungen verwalten.',
+ auditorAlternateText: 'Berichte anzeigen und kommentieren.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 6e0f0cba..2e679533 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -3850,9 +3850,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - Dernière synchronisation le ${formattedDate}`,
authenticationError: (connectionName: string) => `Impossible de se connecter à ${connectionName} en raison d’une erreur d’authentification.`,
learnMore: 'En savoir plus',
- memberAlternateText: 'Les membres peuvent soumettre et approuver des rapports.',
- adminAlternateText: 'Les administrateurs ont un accès complet en modification à tous les rapports et paramètres de l’espace de travail.',
- auditorAlternateText: 'Les auditeurs peuvent consulter et commenter les rapports.',
+ memberAlternateText: 'Soumettre et approuver les rapports.',
+ adminAlternateText: 'Gérez les rapports et les paramètres de l’espace de travail.',
+ auditorAlternateText: 'Afficher et commenter des rapports.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 509be999..39248244 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2004,7 +2004,7 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredDescription: 'Per motivi di sicurezza, Xero richiede l’autenticazione a due fattori per connettere l’integrazione.',
twoFactorAuthIsRequiredForAdminsHeader: 'Autenticazione a due fattori richiesta',
twoFactorAuthIsRequiredForAdminsTitle: 'Abilita l’autenticazione a due fattori',
- twoFactorAuthIsRequiredXero: 'La tua connessione contabile Xero richiede l’uso dell’autenticazione a due fattori. Per continuare a usare Expensify, abilitala.',
+ twoFactorAuthIsRequiredXero: 'La tua connessione contabile a Xero richiede l’uso dell’autenticazione a due fattori. Per continuare a usare Expensify, abilitala.', //_/\__/_/ \_,_/\__/\__/\_,_/
twoFactorAuthIsRequiredCompany: 'La tua azienda richiede l’uso dell’autenticazione a due fattori. Per continuare a usare Expensify, abilitala.',
twoFactorAuthCannotDisable: 'Impossibile disattivare l’autenticazione a due fattori (2FA)',
twoFactorAuthRequired: "Per la tua connessione a Xero è richiesta l'autenticazione a due fattori (2FA) e non può essere disattivata.",
@@ -3829,9 +3829,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - Ultima sincronizzazione ${formattedDate}`,
authenticationError: (connectionName: string) => `Impossibile connettersi a ${connectionName} a causa di un errore di autenticazione.`,
learnMore: 'Scopri di più',
- memberAlternateText: 'I membri possono inviare e approvare i report.',
- adminAlternateText: 'Gli amministratori hanno pieno accesso di modifica a tutti i report e alle impostazioni dello spazio di lavoro.',
- auditorAlternateText: 'I revisori possono visualizzare e commentare i report.',
+ memberAlternateText: 'Invia e approva i report.',
+ adminAlternateText: 'Gestisci i report e le impostazioni dello spazio di lavoro.',
+ auditorAlternateText: 'Visualizza e commenta i report.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8609b55c..bc666075 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2000,8 +2000,8 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredDescription: 'セキュリティ上の理由により、Xero の連携を接続するには二要素認証が必要です。',
twoFactorAuthIsRequiredForAdminsHeader: '2 要素認証が必要です',
twoFactorAuthIsRequiredForAdminsTitle: '二要素認証を有効にしてください',
- twoFactorAuthIsRequiredXero: 'お使いのXero会計連携には二要素認証の利用が必要です。引き続きExpensifyをご利用いただくために、有効にしてください。',
- twoFactorAuthIsRequiredCompany: 'ご利用の会社では二要素認証の使用が必須です。引き続きExpensifyを利用するには、二要素認証を有効にしてください。',
+ twoFactorAuthIsRequiredXero: 'Xero 会計連携には二要素認証の使用が必要です。Expensify を引き続きご利用いただくには、二要素認証を有効にしてください。',
+ twoFactorAuthIsRequiredCompany: 'あなたの会社では二要素認証の利用が必須となっています。Expensify を引き続き利用するには、二要素認証を有効にしてください。',
twoFactorAuthCannotDisable: '2要素認証を無効にできません',
twoFactorAuthRequired: 'Xero 連携には二要素認証（2FA）が必須であり、無効にすることはできません。',
},
@@ -3819,9 +3819,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - 最終同期日 ${formattedDate}`,
authenticationError: (connectionName: string) => `認証エラーのため、${connectionName} に接続できません。`,
learnMore: '詳細はこちら',
- memberAlternateText: 'メンバーはレポートを提出および承認できます。',
- adminAlternateText: '管理者は、すべてのレポートとワークスペース設定を完全に編集できます。',
- auditorAlternateText: '監査担当者はレポートを閲覧し、コメントすることができます。',
+ memberAlternateText: 'レポートを提出して承認します。',
+ adminAlternateText: 'レポートとワークスペースの設定を管理します。',
+ auditorAlternateText: 'レポートを表示してコメントします。',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 41f61ce2..f1a67f77 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2002,8 +2002,8 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredDescription: 'Om veiligheidsredenen vereist Xero tweefactorauthenticatie om de integratie te verbinden.',
twoFactorAuthIsRequiredForAdminsHeader: 'Authenticatie in twee stappen vereist',
twoFactorAuthIsRequiredForAdminsTitle: 'Schakel twee-factor-authenticatie in',
- twoFactorAuthIsRequiredXero: 'Je Xero-boekhoudkoppeling vereist het gebruik van tweeledige verificatie. Schakel dit in om Expensify te blijven gebruiken.',
- twoFactorAuthIsRequiredCompany: 'Uw bedrijf vereist het gebruik van twee-factor-authenticatie. Schakel dit in om Expensify te kunnen blijven gebruiken.',
+ twoFactorAuthIsRequiredXero: 'Uw Xero-accountingkoppeling vereist het gebruik van tweestapsverificatie. Schakel dit in om Expensify te blijven gebruiken.',
+ twoFactorAuthIsRequiredCompany: 'Uw bedrijf vereist het gebruik van tweefactorauthenticatie. Schakel dit in om Expensify te kunnen blijven gebruiken.',
twoFactorAuthCannotDisable: 'Kan 2FA niet uitschakelen',
twoFactorAuthRequired: 'Tweefactorauthenticatie (2FA) is vereist voor je Xero-verbinding en kan niet worden uitgeschakeld.',
},
@@ -3828,9 +3828,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - Laatst gesynchroniseerd ${formattedDate}`,
authenticationError: (connectionName: string) => `Kan geen verbinding maken met ${connectionName} vanwege een authenticatiefout.`,
learnMore: 'Meer informatie',
- memberAlternateText: 'Leden kunnen rapporten indienen en goedkeuren.',
- adminAlternateText: 'Beheerders hebben volledige bewerkingsrechten voor alle rapporten en werkruimte-instellingen.',
- auditorAlternateText: 'Auditors kunnen rapporten bekijken en erop reageren.',
+ memberAlternateText: 'Dien rapporten in en keur ze goed.',
+ adminAlternateText: 'Beheer rapporten en werkruimte-instellingen.',
+ auditorAlternateText: 'Rapporten bekijken en erop reageren.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index c34bac42..e1e31524 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2000,7 +2000,7 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredForAdminsHeader: 'Wymagane uwierzytelnianie dwuskładnikowe',
twoFactorAuthIsRequiredForAdminsTitle: 'Włącz uwierzytelnianie dwuskładnikowe',
twoFactorAuthIsRequiredXero: 'Twoetapowe uwierzytelnianie jest wymagane dla Twojego połączenia księgowego z Xero. Aby nadal korzystać z Expensify, włącz je.',
- twoFactorAuthIsRequiredCompany: 'Twoja firma wymaga używania uwierzytelniania dwuskładnikowego. Aby dalej korzystać z Expensify, włącz je.',
+ twoFactorAuthIsRequiredCompany: 'Twoja firma wymaga używania uwierzytelniania dwuskładnikowego. Aby nadal korzystać z Expensify, włącz je.',
twoFactorAuthCannotDisable: 'Nie można wyłączyć 2FA',
twoFactorAuthRequired: 'Dwuskładnikowe uwierzytelnianie (2FA) jest wymagane dla Twojego połączenia z Xero i nie może zostać wyłączone.',
},
@@ -3824,9 +3824,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} – Ostatnia synchronizacja ${formattedDate}`,
authenticationError: (connectionName: string) => `Nie można połączyć z ${connectionName} z powodu błędu uwierzytelniania.`,
learnMore: 'Dowiedz się więcej',
- memberAlternateText: 'Członkowie mogą przesyłać i zatwierdzać raporty.',
- adminAlternateText: 'Administratorzy mają pełen dostęp do edycji wszystkich raportów i ustawień przestrzeni roboczej.',
- auditorAlternateText: 'Audytorzy mogą przeglądać i komentować raporty.',
+ memberAlternateText: 'Przesyłaj i zatwierdzaj raporty.',
+ adminAlternateText: 'Zarządzaj raportami i ustawieniami przestrzeni roboczej.',
+ auditorAlternateText: 'Przeglądaj i komentuj raporty.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 1981d0e2..d35ac29b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1999,8 +1999,8 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredDescription: 'Por motivos de segurança, a Xero exige autenticação em duas etapas para conectar a integração.',
twoFactorAuthIsRequiredForAdminsHeader: 'Autenticação de dois fatores obrigatória',
twoFactorAuthIsRequiredForAdminsTitle: 'Ative a autenticação em duas etapas',
- twoFactorAuthIsRequiredXero: 'Sua conexão de contabilidade com o Xero requer o uso de autenticação em duas etapas. Para continuar usando o Expensify, ative-a.',
- twoFactorAuthIsRequiredCompany: 'Sua empresa exige o uso de autenticação de dois fatores. Para continuar usando o Expensify, ative-a.',
+ twoFactorAuthIsRequiredXero: 'Sua conexão de contabilidade com a Xero requer o uso de autenticação em duas etapas. Para continuar usando o Expensify, ative-a.',
+ twoFactorAuthIsRequiredCompany: 'Sua empresa exige o uso de autenticação em duas etapas. Para continuar usando o Expensify, ative esse recurso.',
twoFactorAuthCannotDisable: 'Não é possível desativar a 2FA',
twoFactorAuthRequired: 'A autenticação de dois fatores (2FA) é obrigatória para sua conexão com o Xero e não pode ser desativada.',
},
@@ -3822,9 +3822,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - Última sincronização em ${formattedDate}`,
authenticationError: (connectionName: string) => `Não é possível conectar a ${connectionName} devido a um erro de autenticação.`,
learnMore: 'Saiba mais',
- memberAlternateText: 'Os membros podem enviar e aprovar relatórios.',
- adminAlternateText: 'Admins têm acesso total de edição a todos os relatórios e configurações do espaço de trabalho.',
- auditorAlternateText: 'Auditores podem visualizar e comentar em relatórios.',
+ memberAlternateText: 'Enviar e aprovar relatórios.',
+ adminAlternateText: 'Gerencie relatórios e configurações do workspace.',
+ auditorAlternateText: 'Visualize e comente relatórios.',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 15695905..c000acc0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1972,8 +1972,8 @@ const translations: TranslationDeepObject<typeof en> = {
twoFactorAuthIsRequiredDescription: '出于安全原因，Xero 要求使用双重身份验证才能连接此集成。',
twoFactorAuthIsRequiredForAdminsHeader: '需要双重身份验证',
twoFactorAuthIsRequiredForAdminsTitle: '请启用双重身份验证',
- twoFactorAuthIsRequiredXero: '您的 Xero 会计连接需要使用双重身份验证。要继续使用 Expensify，请启用该功能。',
- twoFactorAuthIsRequiredCompany: '您的公司要求使用双重身份验证。要继续使用 Expensify，请启用此功能。',
+ twoFactorAuthIsRequiredXero: '您的 Xero 会计连接需要使用双重身份验证。若要继续使用 Expensify，请启用该功能。',
+ twoFactorAuthIsRequiredCompany: '您的公司要求使用双重身份验证。要继续使用 Expensify，请启用该功能。',
twoFactorAuthCannotDisable: '无法禁用双重身份验证',
twoFactorAuthRequired: '您的 Xero 连接需要启用双重身份验证 (2FA)，且无法将其禁用。',
},
@@ -3767,9 +3767,9 @@ ${
lastSyncDate: ({connectionName, formattedDate}: LastSyncDateParams) => `${connectionName} - 上次同步时间：${formattedDate}`,
authenticationError: (connectionName: string) => `由于身份验证错误，无法连接到 ${connectionName}。`,
learnMore: '了解更多',
- memberAlternateText: '成员可以提交和批准报表。',
- adminAlternateText: '管理员对所有报表和工作区设置拥有完整的编辑权限。',
- auditorAlternateText: '审核员可以查看并评论报表。',
+ memberAlternateText: '提交并审批报表。',
+ adminAlternateText: '管理报表和工作区设置。',
+ auditorAlternateText: '查看并评论报表。',
roleName: ({role}: OptionalParam<RoleNamesParams> = {}) => {
switch (role) {
case CONST.POLICY.ROLE.ADMIN:
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Making this copy more concise (can't find auditor role, but shortening that too):
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
Rolefield and verify that the copy is updated.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari