-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Support card import broken message #78589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 5d09a8e4..034438e6 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7010,7 +7010,7 @@ Fordere Spesendetails wie Belege und Beschreibungen an, lege Limits und Standard
`Beim Synchronisieren mit ${label}${errorMessage ? ` ("${errorMessage}")` : ''} ist ein Problem aufgetreten. Bitte behebe das Problem in den <a href="${workspaceAccountingLink}">Workspace-Einstellungen</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `Die ${feedName} Verbindung ist unterbrochen. Um Kartenimporte wiederherzustellen, <a href='${url}'>melde dich bei deiner Bank an</a>`;
+ return `Die ${feedName}-Verbindung ist unterbrochen. Um Kartenimporte wiederherzustellen, <a href='${url}'>melden Sie sich bei Ihrer Bank an</a>`;
},
addEmployee: (email: string, role: string) => `${email} als ${role === 'member' ? 'a' : 'ein'} ${role} hinzugefügt`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `hat die Rolle von ${email} in ${newRole} geändert (zuvor ${currentRole})`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e643ccee..a1b794ee 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7019,7 +7019,7 @@ Exigez des informations de dépense comme les reçus et les descriptions, défin
`un problème est survenu lors de la synchronisation avec ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Veuillez corriger le problème dans les <a href="${workspaceAccountingLink}">paramètres de l’espace de travail</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `un problème est survenu lors de la synchronisation avec ${feedName}. Pour restaurer les synchronisations de cartes, <a href='${url}'>connectez-vous à votre banque</a>`;
+ return `La connexion ${feedName} est interrompue. Pour rétablir l’importation des cartes, <a href='${url}'>connectez-vous à votre banque</a>`;
},
addEmployee: (email: string, role: string) => `a ajouté ${email} en tant que ${role === 'member' ? 'a' : 'un'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `a mis à jour le rôle de ${email} vers ${newRole} (précédemment ${currentRole})`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index b0224455..5f2acb09 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6993,7 +6993,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
`si è verificato un problema durante la sincronizzazione con ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Risolvi il problema nelle <a href="${workspaceAccountingLink}">impostazioni dello spazio di lavoro</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `La connessione a ${feedName} è interrotta. Per ripristinare le sincronizzazioni di carte, <a href='${url}'>accedi alla tua banca</a>`;
+ return `La connessione ${feedName} è interrotta. Per ripristinare l’importazione delle carte, <a href='${url}'>accedi alla tua banca</a>`;
},
addEmployee: (email: string, role: string) => `aggiunto ${email} come ${role === 'member' ? 'a' : 'un'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `ha aggiornato il ruolo di ${email} in ${newRole} (precedentemente ${currentRole})`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 36ab346c..d291a909 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6937,7 +6937,7 @@ ${reportName}
`${label}${errorMessage ? ` ("${errorMessage}")` : ''} との同期中に問題が発生しました。<a href="${workspaceAccountingLink}">ワークスペース設定</a>で問題を解決してください。`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `The ${feedName} connection is broken. To restore card imports, <a href='${url}'>log into your bank</a>`;
+ return `${feedName} 接続が中断されています。カードの取込を復元するには、<a href='${url}'>銀行にログイン</a>してください`;
},
addEmployee: (email: string, role: string) => `${email} を ${role === 'member' ? 'a' : '1つの'} ${role} として追加しました`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `${email} のロールを ${currentRole} から ${newRole} に更新しました`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 99cce7e1..c958847e 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6980,7 +6980,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
`er is een probleem opgetreden bij het synchroniseren met ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Los het probleem op in de <a href="${workspaceAccountingLink}">werkruimte-instellingen</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `De verbinding met ${feedName} is verbroken. Om kaartimporten te herstellen, <a href='${url}'>log in bij uw bank</a>`;
+ return `De ${feedName}-verbinding is verbroken. Om kaartimport te herstellen, <a href='${url}'>log in bij je bank</a>`;
},
addEmployee: (email: string, role: string) => `${email} toegevoegd als ${role === 'member' ? 'een' : 'een'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `heeft de rol van ${email} gewijzigd naar ${newRole} (voorheen ${currentRole})`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index d426adad..ca23c3db 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6969,7 +6969,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
`wystąpił problem z synchronizacją z ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Proszę naprawić problem w <a href="${workspaceAccountingLink}">ustawieniach przestrzeni roboczej</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `Połączenie z ${feedName} zostało przerwane. Aby przywrócić importy kart, <a href='${url}'>zaloguj się do swojego banku</a>`;
+ return `Połączenie ${feedName} jest przerwane. Aby przywrócić importy kart, <a href='${url}'>zaloguj się do swojego banku</a>`;
},
addEmployee: (email: string, role: string) => `dodano ${email} jako ${role === 'member' ? 'a' : 'jeden'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `zaktualizowano rolę użytkownika ${email} na ${newRole} (poprzednio ${currentRole})`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0d63d47e..e4e5a820 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6972,7 +6972,7 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
`houve um problema ao sincronizar com ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Corrija o problema nas <a href="${workspaceAccountingLink}">configurações do workspace</a>.`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `A conexão com ${feedName} está quebrada. Para restaurar as importações de cartões, <a href='${url}'>faça login no seu banco</a>`;
+ return `A conexão com ${feedName} está interrompida. Para restaurar as importações de cartão, <a href='${url}'>faça login no seu banco</a>`;
},
addEmployee: (email: string, role: string) => `adicionou ${email} como ${role === 'member' ? 'a' : 'um'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `atualizou a função de ${email} para ${newRole} (anteriormente ${currentRole})`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d7f4aa24..dae82a5a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6832,7 +6832,7 @@ ${reportName}
`与 ${label}${errorMessage ? ` ("${errorMessage}")` : ''} 同步时出现问题。请在<a href="${workspaceAccountingLink}">工作区设置</a>中解决该问题。`,
conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
- return `The ${feedName} connection is broken. To restore card imports, <a href='${url}'>log into your bank</a>`;
+ return `${feedName} 连接已中断。若要恢复卡片导入,请<a href='${url}'>登录到您的银行</a>`;
},
addEmployee: (email: string, role: string) => `已将 ${email} 添加为 ${role === 'member' ? 'a' : '一个'} ${role}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `已将 ${email} 的角色更新为 ${newRole}(之前为 ${currentRole})`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
62d23e8 to
7349571
Compare
7349571 to
54c58d2
Compare
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari