Skip to content

Conversation

@nkuoch
Copy link
Contributor

@nkuoch nkuoch commented Dec 30, 2025

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@OSBotify
Copy link
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 5d09a8e4..034438e6 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7010,7 +7010,7 @@ Fordere Spesendetails wie Belege und Beschreibungen an, lege Limits und Standard
                     `Beim Synchronisieren mit ${label}${errorMessage ? ` ("${errorMessage}")` : ''} ist ein Problem aufgetreten. Bitte behebe das Problem in den <a href="${workspaceAccountingLink}">Workspace-Einstellungen</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `Die ${feedName} Verbindung ist unterbrochen. Um Kartenimporte wiederherzustellen, <a href='${url}'>melde dich bei deiner Bank an</a>`;
+                    return `Die ${feedName}-Verbindung ist unterbrochen. Um Kartenimporte wiederherzustellen, <a href='${url}'>melden Sie sich bei Ihrer Bank an</a>`;
                 },
                 addEmployee: (email: string, role: string) => `${email} als ${role === 'member' ? 'a' : 'ein'} ${role} hinzugefügt`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `hat die Rolle von ${email} in ${newRole} geändert (zuvor ${currentRole})`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e643ccee..a1b794ee 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7019,7 +7019,7 @@ Exigez des informations de dépense comme les reçus et les descriptions, défin
                     `un problème est survenu lors de la synchronisation avec ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Veuillez corriger le problème dans les <a href="${workspaceAccountingLink}">paramètres de l’espace de travail</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `un problème est survenu lors de la synchronisation avec ${feedName}. Pour restaurer les synchronisations de cartes, <a href='${url}'>connectez-vous à votre banque</a>`;
+                    return `La connexion ${feedName} est interrompue. Pour rétablir l’importation des cartes, <a href='${url}'>connectez-vous à votre banque</a>`;
                 },
                 addEmployee: (email: string, role: string) => `a ajouté ${email} en tant que ${role === 'member' ? 'a' : 'un'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `a mis à jour le rôle de ${email} vers ${newRole} (précédemment ${currentRole})`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index b0224455..5f2acb09 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -6993,7 +6993,7 @@ Richiedi dettagli di spesa come ricevute e descrizioni, imposta limiti e valori
                     `si è verificato un problema durante la sincronizzazione con ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Risolvi il problema nelle <a href="${workspaceAccountingLink}">impostazioni dello spazio di lavoro</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `La connessione a ${feedName} è interrotta. Per ripristinare le sincronizzazioni di carte, <a href='${url}'>accedi alla tua banca</a>`;
+                    return `La connessione ${feedName} è interrotta. Per ripristinare l’importazione delle carte, <a href='${url}'>accedi alla tua banca</a>`;
                 },
                 addEmployee: (email: string, role: string) => `aggiunto ${email} come ${role === 'member' ? 'a' : 'un'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `ha aggiornato il ruolo di ${email} in ${newRole} (precedentemente ${currentRole})`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 36ab346c..d291a909 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -6937,7 +6937,7 @@ ${reportName}
                     `${label}${errorMessage ? ` ("${errorMessage}")` : ''} との同期中に問題が発生しました。<a href="${workspaceAccountingLink}">ワークスペース設定</a>で問題を解決してください。`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `The ${feedName} connection is broken. To restore card imports, <a href='${url}'>log into your bank</a>`;
+                    return `${feedName} 接続が中断されています。カードの取込を復元するには、<a href='${url}'>銀行にログイン</a>してください`;
                 },
                 addEmployee: (email: string, role: string) => `${email} を ${role === 'member' ? 'a' : '1つの'} ${role} として追加しました`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `${email} のロールを ${currentRole} から ${newRole} に更新しました`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 99cce7e1..c958847e 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -6980,7 +6980,7 @@ Vraag verplichte uitgavedetails zoals bonnetjes en beschrijvingen, stel limieten
                     `er is een probleem opgetreden bij het synchroniseren met ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Los het probleem op in de <a href="${workspaceAccountingLink}">werkruimte-instellingen</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `De verbinding met ${feedName} is verbroken. Om kaartimporten te herstellen, <a href='${url}'>log in bij uw bank</a>`;
+                    return `De ${feedName}-verbinding is verbroken. Om kaartimport te herstellen, <a href='${url}'>log in bij je bank</a>`;
                 },
                 addEmployee: (email: string, role: string) => `${email} toegevoegd als ${role === 'member' ? 'een' : 'een'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `heeft de rol van ${email} gewijzigd naar ${newRole} (voorheen ${currentRole})`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index d426adad..ca23c3db 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -6969,7 +6969,7 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
                     `wystąpił problem z synchronizacją z ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Proszę naprawić problem w <a href="${workspaceAccountingLink}">ustawieniach przestrzeni roboczej</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `Połączenie z ${feedName} zostało przerwane. Aby przywrócić importy kart, <a href='${url}'>zaloguj się do swojego banku</a>`;
+                    return `Połączenie ${feedName} jest przerwane. Aby przywrócić importy kart, <a href='${url}'>zaloguj się do swojego banku</a>`;
                 },
                 addEmployee: (email: string, role: string) => `dodano ${email} jako ${role === 'member' ? 'a' : 'jeden'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `zaktualizowano rolę użytkownika ${email} na ${newRole} (poprzednio ${currentRole})`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 0d63d47e..e4e5a820 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -6972,7 +6972,7 @@ Exija detalhes de despesas como recibos e descrições, defina limites e padrõe
                     `houve um problema ao sincronizar com ${label}${errorMessage ? ` ("${errorMessage}")` : ''}. Corrija o problema nas <a href="${workspaceAccountingLink}">configurações do workspace</a>.`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `A conexão com ${feedName} está quebrada. Para restaurar as importações de cartões, <a href='${url}'>faça login no seu banco</a>`;
+                    return `A conexão com ${feedName} está interrompida. Para restaurar as importações de cartão, <a href='${url}'>faça login no seu banco</a>`;
                 },
                 addEmployee: (email: string, role: string) => `adicionou ${email} como ${role === 'member' ? 'a' : 'um'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `atualizou a função de ${email} para ${newRole} (anteriormente ${currentRole})`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d7f4aa24..dae82a5a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -6832,7 +6832,7 @@ ${reportName}
                     `与 ${label}${errorMessage ? ` ("${errorMessage}")` : ''} 同步时出现问题。请在<a href="${workspaceAccountingLink}">工作区设置</a>中解决该问题。`,
                 conciergeCompanyCardConnectionBroken: ({feedName, policyID}: {feedName: string; policyID: string}) => {
                     const url = `https://new.expensify.com/workspaces/${policyID}/company-cards`;
-                    return `The ${feedName} connection is broken. To restore card imports, <a href='${url}'>log into your bank</a>`;
+                    return `${feedName} 连接已中断。若要恢复卡片导入,请<a href='${url}'>登录到您的银行</a>`;
                 },
                 addEmployee: (email: string, role: string) => `已将 ${email} 添加为 ${role === 'member' ? 'a' : '一个'} ${role}`,
                 updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `已将 ${email} 的角色更新为 ${newRole}(之前为 ${currentRole})`,

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

@nkuoch nkuoch force-pushed the nat-cardimporterrormessage branch from 62d23e8 to 7349571 Compare December 30, 2025 16:32
@nkuoch nkuoch force-pushed the nat-cardimporterrormessage branch from 7349571 to 54c58d2 Compare December 30, 2025 16:36
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 81.73% <ø> (-1.74%) ⬇️
src/libs/ReportActionsUtils.ts 49.73% <100.00%> (-0.24%) ⬇️
src/libs/ReportNameUtils.ts 83.05% <100.00%> (+0.11%) ⬆️
src/libs/ReportUtils.ts 72.87% <50.00%> (-0.08%) ⬇️
src/libs/SidebarUtils.ts 80.96% <50.00%> (-0.14%) ⬇️
src/pages/home/report/PureReportActionItem.tsx 46.97% <50.00%> (-4.77%) ⬇️
...ges/home/report/ContextMenu/ContextMenuActions.tsx 0.78% <0.00%> (-0.01%) ⬇️
... and 111 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants