feat: Add promo offer to Xero on Accounting page #78586
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Ollyws Are you able to review? |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
@mountiny Yeah will do asap. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Let's use the success version of the badge with the green outline. It's currently just the default one |
|
Question for @LLPeckham : Do we want the promo offer even when you're connected to another accounting solution? It's currently built so it only shows when you're not connected: cc @Expensify/design for visibility as well |
|
I think we need to show the badge under the text when on mobile cause it doesn't work: 
Let's wrap it like we're planning on doing on the Uber integration: We don't want the name of the accounting integration to ever be cut off |
| connectButtonText: translate('workspace.accounting.claimOffer.xero.connectButton'), | ||
| connectionName: CONST.POLICY.CONNECTIONS.NAME.XERO, | ||
| featureName: CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED, | ||
| onConnect: () => startIntegrationFlow({name: CONST.POLICY.CONNECTIONS.NAME.XERO}), |
There was a problem hiding this comment.
startIntegrationFlow is never being called in AccountingContextProvider for me, the 'connect to Xero' button is completely unresponsive.
| Navigation.navigate(ROUTES.POLICY_ACCOUNTING_CLAIM_OFFER.getRoute(policyID, CONST.POLICY.CONNECTIONS.NAME.XERO)); | ||
| } | ||
| : undefined, | ||
| badgeStyle: styles.mr3, |
There was a problem hiding this comment.
Did we want the badge outline to be bright green as in: #77750 (comment) ?
4 participants
Explanation of Change
feat: Add promo offer to Xero on Accounting page
Fixed Issues
$ #77750
PROPOSAL: #77750 (comment)
Tests
Offline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-30.at.22.56.55.mov
Android: mWeb Chrome
Screen.Recording.2025-12-30.at.21.51.19.mov
iOS: Native
Screen.Recording.2025-12-30.at.22.56.34.mov
iOS: mWeb Safari
Screen.Recording.2025-12-30.at.21.52.20.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-30.at.21.49.39.mov