-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix single level tags prompt #78569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix single level tags prompt #78569
Conversation
|
will add android/mweb videos shortly |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-hybrid.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: HybridAppios-hybrid.moviOS: mWeb Safariios-mweb.movMacOS: Chrome / Safariweb.mov |
|
🟢 LGTM @Beamanator Consider the PR approved from my side - I wasn't assigned / not able to approve because I asked to be removed temporarely from C+ team for the holidays. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Fixed Issues
$ #76830
PROPOSAL: #76830 (comment)
Tests
Offline tests
Same as above
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-12-30.at.2.49.43.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-12-31.at.12.25.57.AM.mov
iOS: Native
Screen.Recording.2025-12-30.at.12.32.51.PM.mov
iOS: mWeb Safari
Screen.Recording.2025-12-30.at.12.32.01.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-12-30.at.12.13.37.PM.mov