Skip to content

fix: Category no longer valid violation does not appear on expense preview at first #78566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 4 commits into from
Jan 7, 2026
+4 −3
Merged

fix: Category no longer valid violation does not appear on expense preview at first #78566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c5bdf0
fix: Category no longer valid violation does not appear on expense pr…
nkdengineer Dec 30, 2025
c158628
fix test
nkdengineer Dec 30, 2025
0fd9dfc
Merge branch 'main' into fix/77875
nkdengineer Jan 7, 2026
98043d5
fix for taxes
nkdengineer Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import type {MoneyRequestAmountInputProps} from '@components/MoneyRequestAmountInput';
import type {TransactionWithOptionalSearchFields} from '@components/TransactionItemRow';
import type PolicyData from '@hooks/usePolicyData/types';
import {computeReportName} from '@libs/ReportNameUtils';

Check warning on line 26 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Unexpected subpath import via alias '@libs/ReportNameUtils'. Use './ReportNameUtils' instead
import type {PolicyTagList} from '@pages/workspace/tags/types';
import type {ThemeColors} from '@styles/theme/types';
import type {IOUAction, IOUType, OnboardingAccounting} from '@src/CONST';
Expand Down Expand Up @@ -2119,7 +2119,7 @@
// Iterate through all policy reports to find transactions that need optimistic violations
for (const {transactions, violations} of nonInvoiceReportTransactionsAndViolations) {
for (const transaction of Object.values(transactions)) {
const existingViolations = violations[transaction.transactionID];
const existingViolations = violations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`];
const optimisticViolations = ViolationsUtils.getViolationsOnyxData(
transaction,
existingViolations ?? [],
Expand Down
4 changes: 2 additions & 2 deletions src/libs/Violations/ViolationsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ const ViolationsUtils = {

// Add 'categoryOutOfPolicy' violation if category is not in policy
if (!hasCategoryOutOfPolicyViolation && !isCategoryMissing(categoryKey) && !isCategoryInPolicy) {
newTransactionViolations.push({name: 'categoryOutOfPolicy', type: CONST.VIOLATION_TYPES.VIOLATION});
newTransactionViolations.push({name: 'categoryOutOfPolicy', type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true});
}

// Remove 'categoryOutOfPolicy' violation if category is in policy
Expand Down Expand Up @@ -513,7 +513,7 @@ const ViolationsUtils = {
}

if (isPolicyTrackTaxEnabled && !hasTaxOutOfPolicyViolation && !isTaxInPolicy) {
newTransactionViolations.push({name: CONST.VIOLATIONS.TAX_OUT_OF_POLICY, type: CONST.VIOLATION_TYPES.VIOLATION});
newTransactionViolations.push({name: CONST.VIOLATIONS.TAX_OUT_OF_POLICY, type: CONST.VIOLATION_TYPES.VIOLATION, showInReview: true});
}

if (isPolicyTrackTaxEnabled && hasTaxOutOfPolicyViolation && isTaxInPolicy) {
Expand Down
1 change: 1 addition & 0 deletions tests/unit/ViolationUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jest.mock('@libs/actions/Report', () => ({
const categoryOutOfPolicyViolation = {
name: CONST.VIOLATIONS.CATEGORY_OUT_OF_POLICY,
type: CONST.VIOLATION_TYPES.VIOLATION,
showInReview: true,
};

const missingCategoryViolation = {
Expand Down
Loading