-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM #74967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that mileage expenses should have a rate even when added in selfDM
|
@FitseTLT @parasharrajat, the currency edits on unreported distance requests will be disabled as part of this PR |
|
Can you please add test steps @FitseTLT? |
Oh sorry updated @parasharrajat |
|
@parasharrajat what's the ETA on the review? |
|
@trjExpensify I have started review but this can not be merged until we have the taxes PR merged. |
|
@FitseTLT Please merge main. |
|
bump @FitseTLT |
…field-for-track-distance-expenses
|
Sorry for the delay merged @parasharrajat |
|
@FitseTLT can you fix the conflicts? Let's try our best to get this deployed before the week is out! |
…field-for-track-distance-expenses
|
Conflict resolved |
|
@parasharrajat is this waiting on you to review? |
| } | ||
|
|
||
| if (!isPolicyExpenseChat) { | ||
| if (!isPolicyExpenseChat && (!isTrackExpense || !policyForMovingExpensesID)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this different from Category field? Can we use shouldNavigateToUpgradePath here?
| reportID, | ||
| isPolicyExpenseChat, | ||
| policy, | ||
| isTrackDistanceExpense = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of this param? Earlier we were dependent on isPolicyExpenseChat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it for applying the default rate of policyForMovingExpenses on a new track distance expense. To do that we pass policyForMovingExpenses as the policy and set isTrackDistanceExpense to return the default rate. Previously we only returned a policy rate for isPolicyExpenseChat case only.
…field-for-track-distance-expenses
Explanation of Change
Fixed Issues
$ #72230
PROPOSAL:
Tests
Precondition: Have a default workspace with distance rate enabled and several rates created
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-12-06.00-56-10.mp4
Android: mWeb Chrome
2025-12-03.17-53-59.mp4
iOS: Native
2025-12-03.19-40-55.mp4
iOS: mWeb Safari
2025-12-03.17-52-46.mp4
MacOS: Chrome / Safari
2025-12-03.17-52-02.mp4