fix!: upgrade to graphql-kotlin v10 and graphql-java v25#179
Merged
Conversation
danadajian
approved these changes
Jun 5, 2026
renovate
Bot
force-pushed
the
renovate/major-dependencies
branch
from
266b3e9 to
bc51f61
Compare
… graphql-java 25 @NullMarked DataFetcherResult<T> is now @NullMarked in graphql-java 25.0, so Kotlin infers T : Any. Nullable fields still return null at runtime via the @nullable getData() method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danadajian
changed the title
danadajian
pushed a commit
that referenced
this pull request
Jun 5, 2026
BREAKING CHANGE: DataFetcherResult type arguments are now non-nullable to comply with graphql-java 25 @NullMarked annotation
danadajian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.expediagroup:graphql-kotlin-*dependencies and the Gradle plugin from v9.2.0 to v10.0.0, which transitively pulls in graphql-java v25.0DataFetcherResultwith@NullMarked(JSpecify), causing Kotlin to enforceT : Anyon the type parameter. Generated code now uses non-nullable type arguments (e.g.DataFetcherResult<String>instead ofDataFetcherResult<String?>). Null data is still returned at runtime via@Nullable getData()— the GraphQL schema nullability contract is unchanged.DataFetcherResulttype arguments (e.g.DataFetcherResult<String?>) will need to update those signatures after regenerating.