tests: fix --full usages after the scope-flip merge race#42
Merged
Conversation
PR #41 (static-bundle work) was rebased on commit 39d7dd5 and merged after ed41d6f (the --full→--dependencies flip) landed. The squash brought my tests in with --full and no-flag-defaulting-to-node_modules patterns that no longer match the CLI: --full is gone, no-flag now defaults to scope=full, and the nm-scoped popular-npm-modules fixture needs an explicit --dependencies to match its stasis.config.json. Affected: - tests/popular-npm-modules.test.js: static-bundle headlines + 22-cell matrix needed --dependencies for the nm-scoped fixture. Two leftover --full args in the multi-entry test removed (scope=full is now the default). - tests/scan.test.js: captureRuntimeBundle defaulted to no-flag (was node_modules by default), now passes --dependencies when full is false. module-sync regression test drops --full (default is full now). - tests/bundle-cmd.test.js: ERR_MODULE_NOT_FOUND regression test drops --full. All 26 new failures introduced by the merge race are gone (verified locally: 400 of 410 pass; the 10 remaining are the pre-existing mock-matrix byte- equality failures unrelated to this branch). https://claude.ai/code/session_01DqXmS7gzzwuY4AF4wnViob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
PR #41 (static-bundle work) was rebased on commit
39d7dd5and squash-merged aftered41d6f(the--full→--dependenciesflip) landed on main. The squash didn't includeed41d6f's changes to my tests, so they used--fulland no-flag-defaulting-to-node_modulespatterns that no longer match the CLI:--fullwas renamed to default (the implicit polarity is now full-scope)--dependenciesis the new opt-in fornode_modules-onlypopular-npm-modulesfixture isnode_modules-scoped, so its tests need an explicit--dependenciesto avoid env-vs-file scope conflictWhat changed
tests/popular-npm-modules.test.js— static-bundle headlines + 22-cell matrix now pass--dependenciesto match the fixture. Multi-entry test drops--full(default is full now).tests/scan.test.js—captureRuntimeBundlepasses--dependencieswhen not in full mode; module-sync regression drops--full.tests/bundle-cmd.test.js—ERR_MODULE_NOT_FOUNDregression drops--full.Test plan
claude/fix-test-flags-post-fliprebased onto current main. The 10 remaining are the pre-existinglock × bundle × mockbyte-equality failures from PR cli: flip --full to default, replace with --dependencies opt-in #40's--mockfeature, unrelated to this branch.ed41d6f(10 fail) and740a3b8(was 36, now 10).https://claude.ai/code/session_01DqXmS7gzzwuY4AF4wnViob
Generated by Claude Code