Adding OC Fluid Controller support #4
Adding OC Fluid Controller support #4Hasunemiku2015 wants to merge 1 commit intoExeteres:masterfrom Hasunemiku2015:master
Conversation
|
Hi, thanks for the PR! According to the documentation the valid signature for the return value should be like this: getTankCapacity(side: number): LuaMultiReturn<[number?, string?]>;The The optional parameters of the function should be marked like this: drain(amount?: number): boolean;Otherwise they are considered as required. It seems that I didn't notice these problems in one of the latest PRs 🤔 I don't see any more problems here except one... |
|
Okie! I am new to typescript so sorry for my poor code... Also, would you mind me adding AE2 and Mekanism Reactor Support to this thing? (Since I need to use it) |
|
I don't mind. Feel free to add any mod typings you need! |
|
Note that I have extracted component APIs to the separate package, so you need to back-merge the master branch and move your declarations to the |

Trying to add support for OC Fluid Controller, will do the FluidStack thing later.
Check if the current code has any problems.