You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am opening the PR as a way to share and discuss but shouldnt be merged in its current form
This follows up on #210 and are modifications which eventually allowed me to compile and run held_suarez_test_case.py on a Mac (running OS 11.2).
There were several types of issues as you'll see, some of which I uncovered after upgrading to the latest gfortran compiler (v11)
linux system calls which error out on Mac; some I just commented out for now; the affinity part is switched off via a MACOS cpp flag; more or less as done by @jamesp in 2018 (https://github.com/jamesp/Isca/tree/mac)
the -fallow-argument-mismatch and -fallow-invalid-boz part is related to warnings that have recently been turned into errors (the options revert to warnings). Would need a switch like in avoid error message introduced in gfortran 10 MITgcm/MITgcm#480 probably for gfortran < v10
in create_xgrid.c I needed to add a definition of isHeadNode_b (same as in mosaic_util.c but for the name)
added gfortran_mac option file
Maybe this could get reviewed and merged after some revision. Please chime in
@gaelforget Quick question: do you have an intuition for whether or not the additional changes you've made (i.e., beyond those in Jamie's branch) would affect compilation on Mac setups for which Isca currently does compile (i.e., what Jamie had working)?
@gaelforget Quick question: do you have an intuition for whether or not the additional changes you've made (i.e., beyond those in Jamie's branch) would affect compilation on Mac setups for which Isca currently does compile (i.e., what Jamie had working)?
Except for the -fallow-argument-mismatch and -fallow-invalid-boz part that need to be skipped with gfortran < 10 (see MITgcm/MITgcm#480) I would think so. Would be awesome if you could double check that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening the PR as a way to share and discuss but shouldnt be merged in its current form
This follows up on #210 and are modifications which eventually allowed me to compile and run
held_suarez_test_case.pyon a Mac (running OS 11.2).There were several types of issues as you'll see, some of which I uncovered after upgrading to the latest gfortran compiler (v11)
MACOScpp flag; more or less as done by @jamesp in 2018 (https://github.com/jamesp/Isca/tree/mac)-fallow-argument-mismatchand-fallow-invalid-bozpart is related to warnings that have recently been turned into errors (the options revert to warnings). Would need a switch like in avoid error message introduced in gfortran 10 MITgcm/MITgcm#480 probably for gfortran < v10create_xgrid.cI needed to add a definition ofisHeadNode_b(same as inmosaic_util.cbut for the name)gfortran_macoption fileMaybe this could get reviewed and merged after some revision. Please chime in