Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Conversation

@R2kip
Copy link

@R2kip R2kip commented May 30, 2025

Description

Describe the changes
The previous transpiler ignored game checks and was unstable.
SwingingEventArgs has been renamed to SwingingJailbirdEventArgs to make it clear that the event is related to Jailbird.
SwingingEventArgs.IsAllowed has been renamed to SwingingEventArgs.CanHurt, as it was the event that prevented damage from being dealt, not the event itself.

What is the current behavior? (You can also link to an open issue here)
😖

What is the new behavior? (if this is a feature change)
🤩

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Replace:
SwingingEventArgs -> SwingingJailbirdEventArgs
SwingingEventArgs.IsAllowed -> SwingingEventArgs.CanHurt


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@R2kip R2kip changed the title fix: Rework Jailbird events fix: Rework Jailbird transpiler May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant