This repository was archived by the owner on Jul 8, 2025. It is now read-only.
feat: Handle null scalars for nullable Vector types in YAML deserialization #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Added handling for null scalar values when deserializing nullable Unity Vector2, Vector3, and Vector4 types from YAML configs.
This prevents exceptions when the YAML explicitly sets vector properties to null.
For non-nullable vectors, the deserializer behavior remains unchanged and will throw an error if null is provided.
What is the current behavior?
Currently, deserializing null for non-nullable vector properties causes unhandled exceptions. Nullable vectors are not properly handled when set to null in the YAML.
(https://discord.com/channels/656673194693885975/1375421848510271589)
What is the new behavior?
Nullable vectors can now safely accept null values from YAML, returning null without errors. Non-nullable vectors still throw an exception if assigned null.
Does this PR introduce a breaking change?
No. Existing non-nullable vector properties maintain their behavior. This change only improves nullable vector support and error handling.
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other