Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Conversation

@Banalny-Banan
Copy link

Description

Describe the changes
Fixed and updated shot event. Bug report: https://discord.com/channels/656673194693885975/1375077709960581182

What is the current behavior? (You can also link to an open issue here)
🥺👉📉

What is the new behavior? (if this is a feature change)
😊👍

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

@Banalny-Banan
Copy link
Author

Im working on a transpiler currently

@Banalny-Banan
Copy link
Author

Wasted an hour trying, it still doesnt work, I have more important stuff to do then microoptimize a single method call and quite frankly prefix is more maintainable here

@Banalny-Banan Banalny-Banan changed the title Fix: Shot event not working correctly fix: Shot event not working correctly May 22, 2025
@Banalny-Banan Banalny-Banan marked this pull request as draft May 22, 2025 22:20
@Banalny-Banan
Copy link
Author

Banalny-Banan commented May 22, 2025

Turned out it can cause an exception and therefore disconnect the client in some conditions I can't consistently reproduce. There is nothing more I can do, im gonna stick with a prefix on a fork. If someone is willing to make a working 1:1 transpiler with a try-catch statement it would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant