Skip to content

Conversation

@michcio15
Copy link

Description

Describe the changes
Adds a new event which is invoked after a player stop "talking with the dead" using scp - 1576

What is the current behavior? (You can also link to an open issue here)
Well there is no

What is the new behavior? (if this is a feature change)
The event exists

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@michcio15 michcio15 changed the title Adds a new event for when SCP-1576 stops being used feat : Adds a new event for when SCP-1576 stops being used Dec 22, 2025
@michcio15 michcio15 changed the title feat : Adds a new event for when SCP-1576 stops being used feat: Adds a new event for when SCP-1576 stops being used Dec 22, 2025
Copy link
Collaborator

@Someone-193 Someone-193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a very good PR, could use some changes though to better conform to Exileds standards. Nice job 👍!

michcio15 and others added 2 commits December 22, 2025 19:28
@michcio15
Copy link
Author

I think i changed it to match your suggestions

@louis1706 louis1706 changed the base branch from master to dev December 25, 2025 10:38
@louis1706
Copy link

Remind to always target dev except if your change only contain doc change

@michcio15
Copy link
Author

michcio15 commented Dec 25, 2025

Remind to always target dev except if your change only contain doc change

Ok

@michcio15
Copy link
Author

What now?

@louis1706 louis1706 merged commit f31a037 into ExMod-Team:dev Dec 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants