-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Adds a new event for when SCP-1576 stops being used #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Someone-193
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a very good PR, could use some changes though to better conform to Exileds standards. Nice job 👍!
EXILED/Exiled.Events/EventArgs/Scp1576/TransmissionEndedEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Player/Scp1576TransmissionEndedEventArgs.cs
Show resolved
Hide resolved
EXILED/Exiled.Events/EventArgs/Scp1576/TransmissionEndedEventArgs.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/Patches/Events/Scp1576/TransmissionEnded.cs
Outdated
Show resolved
Hide resolved
EXILED/Exiled.Events/Patches/Events/Scp1576/TransmissionEnded.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com>
|
I think i changed it to match your suggestions |
Change comments
|
Remind to always target dev except if your change only contain doc change |
Ok |
|
What now? |
Description
Describe the changes
Adds a new event which is invoked after a player stop "talking with the dead" using scp - 1576
What is the current behavior? (You can also link to an open issue here)
Well there is no
What is the new behavior? (if this is a feature change)
The event exists
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other