fix: Missing Event Patch Arttiburets #685
Conversation
louis1706
left a comment
louis1706
left a comment
There was a problem hiding this comment.
Thanks for your check but yes some was needed to not be there but yeah we are missing some information about them in the documentation than you can add now :3
| /// <summary> | ||
| /// Patches <see cref="Scp049SenseAbility.ServerProcessCmd" />. | ||
| /// Adds the <see cref="Handlers.Scp049.ActivatingSense" /> event. | ||
| /// </summary> | ||
| [EventPatch(typeof(Handlers.Scp049), nameof(Handlers.Scp049.ActivatingSense))] | ||
| [HarmonyPatch(typeof(Scp049SenseAbility), nameof(Scp049SenseAbility.ServerProcessCmd))] |
There was a problem hiding this comment.
this is mostly missing Documentation but yeah it's normal that the EventPatch is missing there Config "CanScp049SenseTutorial" and the "Scp049Role.TurnedPlayers" behaviours always required this event to be patch anyways
you can edit the doc above to make this noted
| /// Patches <see cref="Scp3114Dance.ServerProcessCmd"/> | ||
| /// to add <see cref="Handlers.Scp3114.Dancing"/> event. | ||
| /// </summary> | ||
| [EventPatch(typeof(Handlers.Scp3114), nameof(Handlers.Scp3114.Dancing))] |
There was a problem hiding this comment.
this is required for the "Scp3114.NextDanceType" behaviours but yes documentation above it should representing that
| /// Patches <see cref="CharacterClassManager.Start" />. | ||
| /// Adds the <see cref="Handlers.Server.WaitingForPlayers" /> event. | ||
| /// </summary> | ||
| [EventPatch(typeof(Handlers.Server), nameof(Handlers.Server.WaitingForPlayers))] |
There was a problem hiding this comment.
with that added an no plugin calling this event it's would make Server.Host being null causing a lot of issue
(same as said above you can make that said in the documentation above
3 participants
Description
Describe the changes
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other