Fix last few redis events not consistently publishing#174
Open
Fix last few redis events not consistently publishing#174
Conversation
alehuo
requested changes
Apr 4, 2026
| counter: Dict[str, int], | ||
| counter_lock: asyncio.Lock, | ||
| client: AsyncClient, | ||
| update_interval: int = 5, |
Collaborator
There was a problem hiding this comment.
If there are less than five tasks, will this fail?
Should the update_interval be min(5, task_count)?
Collaborator
Author
There was a problem hiding this comment.
There is a final redis event publish in process_job() after the tasks have completed. So it should just go from 0 to completed in a case where it is less than 5.
I'll test.
Though the celery progress will not be updated in that case... Is the celery state and meta used for anything else than tracking/debugging in flower?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug where the last few Redis job progress events would not consistently publish.
Add a final event publish after tasks have completed.
Add buffering controlled with
update_intervalparameter which is set to 5 by default. Maybe having a time based event update would be slightly better and would cover both small and larger screening tasks.Resolves #170