Merged
Conversation
There's now nothing downstream that needs python3.9. And we might as well upgrade to the newer python3.12 patch as well :^)
Before this, our CI runs were spitting out deprecation warnings like
/__work/libpff/libpff/venv/lib/python3.12/site-packages/setuptools/dist.py:483: SetuptoolsDeprecationWarning: Please provide a valid glob pattern.
!!
********************************************************************************
Pattern 'COPYING COPYING.LESSER' contains invalid characters.
By 2026-Mar-20, you need to update your project and remove deprecated calls
or your builds will no longer be supported.
See https://packaging.python.org/en/latest/specifications/glob-patterns/ for details.
********************************************************************************
!!
for path in sorted(cls._find_pattern(pattern, enforce_match))
https://github.com/Everlaw/libpff/actions/runs/19642110034/job/56249042533#step:8:8
According to https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#metadata,
this is a "list-comma" field, which is a "dangling list or string of
comma-separated values".
Collaborator
Author
|
@will-frazier do you have bandwidth to review? |
|
LGTM, thanks @kmurphy4 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, our CI runs were spitting out deprecation warnings like
According to https://setuptools.pypa.io/en/latest/userguide/declarative_config.html#metadata, this is a "list-comma" field, which is a "dangling list or string of comma-separated values".