Conversation
Bump TAS Check dependencies
SnipUndercover
left a comment
There was a problem hiding this comment.
As described under f6b06c3, this change was made to prevent the same Dialog Cutscene Trigger from being activated multiple times via something like Crystalline's Trigger Trigger.
Previously this was not the case, as the cutscene trigger just immediately removed itself after being activated. This check was designed to prevent this situation and bring the behavior more in line with how it was before this PR.
The consensus was to allow multiple separate cutscenes to play concurrently, but not the same one. I guess this could be accomplished by setting a flag for the duration of the cutscene and simply bailing out early if the flag is set. While this would also be useful for mappers, I'm not 100% sure whether this would be something that should be in Everest.
(it probably is but i dunno)
|
I am unable to reproduce the issue with "Crystalline's Trigger Trigger" so far, so I'm marking this PR as draft for now. |
Follow up on #999, this PR removes the check preventing multiple cutscenes from running concurrently.
Running multiple cutscenes concurrently is usually not desirable for a player/mapper, but it is currently used by TASes.
The consensus right now is to allow this behavior.
This change was tested against Monika's D-Sides - Trust chapter TAS:
hh-01