Skip to content

Allow concurrent cutscenes#1081

Draft
DashingCat wants to merge 3 commits intoEverestAPI:devfrom
DashingCat:allow-concurrent-cutscenes
Draft

Allow concurrent cutscenes#1081
DashingCat wants to merge 3 commits intoEverestAPI:devfrom
DashingCat:allow-concurrent-cutscenes

Conversation

@DashingCat
Copy link
Contributor

Follow up on #999, this PR removes the check preventing multiple cutscenes from running concurrently.

Running multiple cutscenes concurrently is usually not desirable for a player/mapper, but it is currently used by TASes.
The consensus right now is to allow this behavior.

This change was tested against Monika's D-Sides - Trust chapter TAS:

  • without this change, there is a desync in the room hh-01
  • with this change, the TAS runs normally

Copy link
Member

@SnipUndercover SnipUndercover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described under f6b06c3, this change was made to prevent the same Dialog Cutscene Trigger from being activated multiple times via something like Crystalline's Trigger Trigger.
Previously this was not the case, as the cutscene trigger just immediately removed itself after being activated. This check was designed to prevent this situation and bring the behavior more in line with how it was before this PR.

The consensus was to allow multiple separate cutscenes to play concurrently, but not the same one. I guess this could be accomplished by setting a flag for the duration of the cutscene and simply bailing out early if the flag is set. While this would also be useful for mappers, I'm not 100% sure whether this would be something that should be in Everest.
(it probably is but i dunno)

@maddie480-bot maddie480-bot added the 2: changes requested This PR cannot be merged because changes were requested (bot-managed) label Jan 29, 2026
@DashingCat
Copy link
Contributor Author

I am unable to reproduce the issue with "Crystalline's Trigger Trigger" so far, so I'm marking this PR as draft for now.

@DashingCat DashingCat marked this pull request as draft February 11, 2026 21:43
@maddie480-bot maddie480-bot added 0: draft This PR is not ready for review yet (bot-managed) and removed 2: changes requested This PR cannot be merged because changes were requested (bot-managed) labels Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0: draft This PR is not ready for review yet (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants