Skip to content

Add null checks in EntityRegistry.RegisterSidToTypeConnection#1052

Merged
maddie480 merged 1 commit intoEverestAPI:devfrom
JaThePlayer:fix-RegisterSidToTypeConnectionNRE
Mar 17, 2026
Merged

Add null checks in EntityRegistry.RegisterSidToTypeConnection#1052
maddie480 merged 1 commit intoEverestAPI:devfrom
JaThePlayer:fix-RegisterSidToTypeConnectionNRE

Conversation

@JaThePlayer
Copy link
Copy Markdown
Member

Fixes crashes with manually created EntityData instances, like in Frost Helper Ice Keys: https://discord.com/channels/403698615446536203/1455101704142979154/1455101704142979154

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Dec 29, 2025
@maddie480-bot
Copy link
Copy Markdown
Member

The pull request was approved and entered the 3-day last-call window.
If no further reviews happen, it will end on Mar 17, 2026, 12:12 PM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Mar 14, 2026
@maddie480-bot
Copy link
Copy Markdown
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Mar 17, 2026
@maddie480 maddie480 merged commit 8227a15 into EverestAPI:dev Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants