Skip to content

fix(openclaw): saveMemories posts PersonalAddRequest envelope with top-level user_id (closes #237)#244

Closed
Fearvox wants to merge 668 commits into
EverMind-AI:mainfrom
Fearvox:fix/issue-237-personaladd-envelope
Closed

fix(openclaw): saveMemories posts PersonalAddRequest envelope with top-level user_id (closes #237)#244
Fearvox wants to merge 668 commits into
EverMind-AI:mainfrom
Fearvox:fix/issue-237-personaladd-envelope

Conversation

@Fearvox
Copy link
Copy Markdown
Collaborator

@Fearvox Fearvox commented Jun 3, 2026

What

POST /api/v1/memories returned HTTP 422 "Field required: user_id" because
saveMemories sent flat, per-message bodies with no top-level user_id. The v1
PersonalAddRequest DTO is an envelope: a required top-level user_id plus
a messages[] list of MessageItem, and each MessageItem requires an integer
unix-milliseconds timestamp. This is the exact defect in #237.

This PR rewrites saveMemories to send a single batched envelope and align each
item with the DTO:

{ user_id, session_id?, messages: [ { message_id, timestamp, role, sender_name, content, sender_id? } ] }
  • timestamp: required unix-ms integer. The old create_time ISO string was
    ignored by the converter, leaving timestamp missing → 422.
  • sender_id: set to user_id only for role=user; omitted for
    role=assistant so the backend derives a distinct id (the personal-scene
    converter rejects assistant turns whose sender_id equals user_id).
  • session_id: plumbed through from the OpenClaw sessionKey (engine.js)
    for conversation isolation; optional in the DTO.

Why

Without a top-level user_id the request never passes validation, so the plugin
silently persisted nothing — every turn 422'd. Posting one batched envelope
also replaces the previous one-request-per-message loop.

Verification

Live against a running EverCore (:1995):

body result
old flat per-message body HTTP 422 {"message":"Field required: user_id"}
new envelope (this PR) HTTP 200 {"status":"accumulated","message":"Messages accepted"}

The real saveMemories() from this branch was also driven against the live
backend end-to-end and the POST was accepted (2xx).

Offline regression — adds test/save-memories.test.js (node --test, no
live stack): asserts a single batched POST to /api/v1/memories whose body
carries a top-level user_id, a session_id, a messages array with integer
timestamps and no legacy create_time, and the correct per-role sender_id
semantics; plus that an empty batch sends nothing.

cd methods/EverCore/examples/openclaw-plugin
node --test test/save-memories.test.js

Result: 2 passed.

Scope

Surgical: src/api.js (the envelope rewrite) + the src/engine.js one-line
sessionId plumbing + its regression test. Deliberately does not bundle the
separate api.pluginConfig forwarding fix (#150), which ships as its own PR.

Closes #237.

Credit

Prior art adopted:

Co-authored-by: kevinwon 2725361+ww-k@users.noreply.github.com
Co-authored-by: Void Freud 246163318+voidfreud@users.noreply.github.com
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

🤖 Generated with Claude Code

libin.zhang and others added 30 commits December 31, 2025 18:23
Use self-deployed embedding and rerank APIs by default

See merge request npc-work/aic/ai/evermemos-opensource!64
vLLM Rerank API adopts an instruction-tuned approach

See merge request npc-work/aic/ai/evermemos-opensource!65
feat: metrics client and rerank/vectorize/retrieve metrics

See merge request npc-work/aic/ai/evermemos-opensource!66
fix:update episode prompt

See merge request npc-work/aic/ai/evermemos-opensource!68
feat: add rerank metrics

See merge request npc-work/aic/ai/evermemos-opensource!69
cyfyifanchen and others added 25 commits April 27, 2026 03:42
* chore: rename project from evermemos to EverCore

This commit renames the project directory and updates all internal references from "evermemos" to "EverCore". The changes include:
- Renaming the main directory from `methods/evermemos` to `methods/EverCore`
- Updating all import paths and module references
- Maintaining the same code structure and functionality
- Adding new configuration files (.vscode/settings.json, .pylintrc, pyrightconfig.json)
- Updating Dockerfile and project metadata

* docs: update references from evermemos to EverCore

Update documentation files to reflect the renaming of the 'evermemos' directory to 'EverCore'. This includes fixing clone commands, directory paths, and documentation links across multiple files to ensure consistency and correct navigation for users.

* chore: rename EverMemOS to EverCore across codebase

This is a project-wide rebranding from EverMemOS to EverCore. The changes include:
- Update project name in source files, documentation, and configuration
- Rename API references, environment variables, and service names
- Modify demo descriptions and benchmark configurations
- Update URLs and citations to reflect new project identity

All functionality remains identical; only naming has changed to align with the new project branding.

* docs: update README with EverCore focus and restructured TOC

- Add line break before Table of Contents for better visual separation
- Rewrite project description to highlight EverCore as the central component
- Reorder directory tree to prioritize benchmarks and methods over use-cases
- Update use-cases list with more examples and clarify they are templates
- Improve flow from Quick Start to use-cases to benchmarks

* docs: update README with clearer methods description and benchmarks

Add benchmark numbers directly in the method summaries for better visibility.
Clarify introductory text to emphasize choice and composition of methods.

* docs: fix markdown formatting in README table of contents

Adjust whitespace and line breaks to ensure proper rendering of the collapsible table of contents section.
…d-AI#204)

- Replace specific EverMemBench-Dynamic badge with general EverMind-AI HuggingFace badge
- Remove redundant License badge
- Change "Methods" section heading to "Architecture Methods"
- Update sub-section headings from h4 (####) to h3 (###) for better hierarchy
…rMind-AI#208)

* docs: restructure README and add AGENTS.md for better navigation

- Reorder sections to emphasize architecture methods and use cases
- Move use cases section before quick start for better flow
- Rename "Methods" to "Architecture Methods" for clarity
- Add AGENTS.md with quick commands and key entry points
- Update section headers to improve document hierarchy
- Maintain all existing content while improving organization

* docs: add community and contribution files

* docs: reorder README directory tree for logical grouping

* docs: move community files to .github/ and update references

* ci: change deploy workflow trigger from feature branch to main
* docs: restructure README and add subdirectory guides

Move the directory tree from the main README to new dedicated README files for each top-level folder (use-cases, methods, benchmarks). Add detailed introductions and tables to guide users to the appropriate subprojects. This improves navigation and provides clear entry points for different use cases.

* docs: expand showcase section with new projects and links

Add six new project entries to the README showcase, each with a banner image, description, and code/plugin link. Also update an existing benchmark entry to include a dataset link. This enhances the repository's demonstration of real-world applications and available resources.
* docs(readme): update project links and formatting

* docs(use-cases): enhance README with visual catalogue of demos

Expand the use cases section from a simple table to a detailed visual catalogue with project banners, descriptions, and links. This improves user engagement and provides a better showcase of community integrations and demos.

* docs: update READMEs and add validation for use-case links
* docs: update plugin repository link in README

* docs(readme): update banner gif link
)

* docs(readme): update code example link to pinned commit

pin the reference to the voice assistant example code to a specific commit hash and fix folder name capitalization

* docs: update voice assistant demo link in README
* docs(readme): add four new use case entries

* docs(readme): update outdated banner links to correct github repos
…e-demo-content-payload

Fix EverCore demo memory payload
…actions-hygiene

Harden GitHub Actions workflows
…adme-quickstart

docs: verify EverCore quickstart path
…I#236)

Delete deprecated EvoAgentBench, EverMemBench benchmark suites and
HyperMem memory system implementation, including all associated
configurations, scripts, and supporting assets.
…top-level user_id (closes EverMind-AI#237)

POST /api/v1/memories returned HTTP 422 ("Field required: user_id") because
saveMemories sent flat, per-message bodies with no top-level user_id. The v1
PersonalAddRequest DTO is an envelope: a required top-level user_id plus a
messages[] list of MessageItem, and each MessageItem requires an integer
unix-milliseconds timestamp.

Rewrite saveMemories to send a single batched envelope { user_id, session_id?,
messages: [...] } and align each item with the MessageItem DTO:
- timestamp: required unix-ms integer (the old create_time ISO string was
  ignored by the converter, leaving timestamp missing -> 422).
- sender_id: set to user_id only for role=user; omitted for role=assistant so
  the backend derives a distinct id (personal-scene converter rejects assistant
  turns whose sender_id equals user_id).
- session_id: plumbed through from the OpenClaw sessionKey (engine.js) for
  conversation isolation; optional in the DTO.

Verified live against a running EverCore on :1995: the old flat body returns
422 "Field required: user_id"; the new envelope returns 200
{"status":"accumulated","message":"Messages accepted"}.

Adds test/save-memories.test.js (node --test, offline) asserting the POST body
carries a top-level user_id, a session_id, a messages array with integer
timestamps and no legacy create_time, and the correct per-role sender_id
semantics; plus that an empty batch sends nothing.

Scope: api.js + the engine.js sessionId plumbing + its regression test. Does not
bundle the separate api.pluginConfig forwarding fix (EverMind-AI#150/EverMind-AI#139), which ships as
its own PR.

Prior art adopted: PR EverMind-AI#189 (kevinwon) converted saveMemories to the same
top-level-user_id batch envelope; PR EverMind-AI#128 (Void Freud) set user_id at the top
level in the same saveMemories path.

Closes EverMind-AI#237.

Co-authored-by: kevinwon <2725361+ww-k@users.noreply.github.com>
Co-authored-by: Void Freud <246163318+voidfreud@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 3, 2026 05:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] OpenClaw plugin saveMemories: POST /api/v1/memories 422 (Field required: user_id)