Ensure outbox stores message with same headers as regular repository#38
Open
axlon wants to merge 1 commit intoEventSaucePHP:mainfrom
Open
Ensure outbox stores message with same headers as regular repository#38axlon wants to merge 1 commit intoEventSaucePHP:mainfrom
axlon wants to merge 1 commit intoEventSaucePHP:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to EventSaucePHP/EventSauce#247
Currently when a message is persisted, the event ID is not set until the very last moment (when the message is inserted into the database). This causes outbox repositories and message dispatchers to receive message instances that do not have this header set.
This PR changes the transactional message repositories to set the event ID at the start of the transaction, only if the event ID is not already set. This makes it so the message and outbox repository both receive the same headers. The limitation of this approach (as opposed to EventSaucePHP/EventSauce#247) is that when using an aggregate root repository, the message dispatcher will still receive stale instances. A workaround for that issue could be to simply use a MessageDecorator instead of relying on the message repositories.