Document units for ExponentialBackOffStrategy parameters#11
Open
oxan wants to merge 1 commit intoEventSaucePHP:mainfrom
Open
Document units for ExponentialBackOffStrategy parameters#11oxan wants to merge 1 commit intoEventSaucePHP:mainfrom
oxan wants to merge 1 commit intoEventSaucePHP:mainfrom
Conversation
"ms" is commonly understood to be milliseconds, but is used for microseconds (commonly denoted as us) here. Add a docblock to make it clear that this deviates from the convention.
|
This would have confused us as well. Any chance this can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ms" is commonly understood to be milliseconds, but is used for microseconds (commonly denoted as us) here. Add a docblock to make it clear that this deviates from the convention.
I opted not to change the argument name, as with named arguments that would be a backward compatibility break.