Skip to content

Conversation

@LMLiam
Copy link
Collaborator

@LMLiam LMLiam commented Jan 19, 2026

Description

  • Remove the Foojay toolchains settings plugin from settings.gradle to avoid mandatory plugin resolution during settings evaluation.
  • Add support in the processor/annotation code for no-arg @ServiceProvider usage by giving ServiceProvider a default empty value and implementing inferContractsFromProvider in ServiceSchemeProcessor to BFS supertypes and collect @ServiceContract interfaces; emit a clear compilation error when none can be inferred.
  • Add unit tests covering no-arg provider inference and the error case in ServiceSchemeProcessorSpec.kt.

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8aa16d6ce6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0'
}

rootProject.name = 'spi-tooling'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep a Java 24 toolchain source configured

Removing the Foojay toolchains resolver here means Gradle no longer has any toolchain download repository configured. The modules still request Java 24 toolchains (see modules/annotations/build.gradle and modules/processor/build.gradle), so any environment without a locally installed JDK 24 will now fail toolchain resolution with “no compatible toolchain” instead of provisioning one. If the intent is to avoid network access during settings evaluation, consider an alternative local toolchain repo configuration or lowering the toolchain version to what’s already installed rather than dropping resolver support entirely.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants