Skip to content

Conversation

@LMLiam
Copy link
Collaborator

@LMLiam LMLiam commented Oct 30, 2025

📌 Summary

As seen in LMLiam/microsmith#10, it is unexpected that a defined contract should cause compilation failure if there are no providers. However, it is still an expected case of failure if a provider does not annotate with @Serviceprovider.

🔍 Related Issues / Tickets

No related issue.

🛠 Changes in Detail

  • Reworked the processor to ensure that
    • Compilation still fails if providers are specified without the annotation
    • Compilation does not fail if a contract is defined with no providers

🧩 Modules Affected

  • spi-tooling-annotations
  • spi-tooling-processor
  • Other:

📦 Versioning

  • Version bump applied (release PR)
  • Snapshot only (PR build)

🧪 Testing

  • Steps:
    1. Updated automatic tests, specifically the error cases to take in a result which allows us to control whether the expected compilation fails or succeeds.

✅ Checklist

  • Code builds locally without errors
  • All tests pass locally (./gradlew kotest)
  • Added/updated tests for new or changed logic
  • Updated documentation / README if needed
  • No unrelated changes included

📜 Notes for Reviewers

@github-actions
Copy link

🆕 PR Snapshot Published to Maven Central Snapshot Repository

You can test this PR build by adding the following dependencies:

Version: 0.1.21-PR11-1761835243-SNAPSHOT

implementation "io.github.eventhorizonlab:spi-tooling-annotations:0.1.21-PR11-1761835243-SNAPSHOT"
kapt "io.github.eventhorizonlab:spi-tooling-processor:0.1.21-PR11-1761835243-SNAPSHOT"

This comment will be updated automatically if a new snapshot is published for this PR

@LMLiam LMLiam marked this pull request as ready for review October 30, 2025 14:41
@LMLiam LMLiam merged commit 83c932e into main Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants